Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #361 - Group signals into satellites for correct dual-frequency used/in view counts #355

Merged
merged 30 commits into from
Jan 23, 2020
Merged

Fix #361 - Group signals into satellites for correct dual-frequency used/in view counts #355

merged 30 commits into from
Jan 23, 2020

Conversation

barbeau
Copy link
Owner

@barbeau barbeau commented Oct 23, 2019 •
edited
Loading

Work-in-progress - Please do not merge

TODO:

  • Implement logic to group satellite signals into satellite objects
  • Unit tests
  • Update Travis to run on newer API emulator so tests pass on newer API levels - done in Manually install JDK and Android SDK on Travis #362
  • Update unit tests so they also pass on API levels <= 25 (which don't support CF)
  • Add more tests to validate in view / used counts for signals and satellites - make sure they all pass locally and on Travis
  • Surface info in UI

@barbeau
Start of DeviceInfoViewModel for holding device info
e6940c2
@barbeau
Implement logic to group satellite signals into satellite objects
3738619 
* Includes flagging duplicate constellation/ID/carrier signals, as well as unknown carrier frequencies.
* Includes detecting if dual-frequency signals are in view and in use
@barbeau
Add getters for duplicate and unknown signal maps
c5fb817
@barbeau barbeau added this to the v3.5 milestone Oct 23, 2019
This was referenced Oct 23, 2019
Closed
Open
Closed
Closed
@barbeau
Create satellite and status keys specific to SBAS constellations
8504630 
This ensures we don't have ID collisions between different SBAS constellations
@barbeau
Merge branch 'master' into device-info
02ac3bc
@barbeau
Refactor utility classes/methods
88c29d8 
Move most of the non-satellite/signal utilities out of GPSTestUtil and rename it to SatelliteUtils
@barbeau
Start to add tests for generating satellite/signal keys
257f4a8 
Refactor carrier freq. label utilities to include unknown/unsupported

TODO - fix failing tests from refactor
@barbeau
Convert Carrier freq utils from Java to Kotlin, start fixing tests
ebb7d31
@barbeau
Fix remaining tests
62e6c63 
* Move to instrumented tests for "unknown" values
* Move constants from strings to code
* Bump test runner dependency
@barbeau
Start adding tests for device view model
dd18394
@barbeau
Refactor some satellite code, add another test (which currently fails)
c6c1f78
@barbeau
Fix tests
5b154a7
@barbeau
Add ability to test if any L5 is in view or use, more tests
51ca4c6
@barbeau
Rename methods to be more accurate
c4b6ae5
@barbeau
Add Galileo test for dual-frequency, refactor test utilities
1a2a5f9
@barbeau
Refactor variable to match actual signal label
4bab23d
@barbeau
Add SBAS tests
5332c05
@barbeau barbeau mentioned this pull request Jan 10, 2020
Closed
@barbeau barbeau changed the title WIP - Group signals into satellite objects Fix #361 - Group signals into satellites for correct used/in view counts Jan 22, 2020
@barbeau barbeau changed the title Fix #361 - Group signals into satellites for correct used/in view counts Fix #361 - Group signals into satellites for correct dual-frequency used/in view counts Jan 22, 2020
@barbeau barbeau merged commit 174d25e into master Jan 23, 2020
@barbeau barbeau deleted the device-info branch January 23, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.
1 participant
@barbeau