Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate errors in CF output in UI #295

Closed
barbeau opened this issue May 16, 2019 · 3 comments
Closed

Indicate errors in CF output in UI #295

barbeau opened this issue May 16, 2019 · 3 comments

Comments

@barbeau
Copy link
Owner

barbeau commented May 16, 2019

Summary:
As mentioned in https://forum.xda-developers.com/showpost.php?p=79538493&postcount=245 and shown in https://medium.com/@papylepian/mi-9-9140f7db50da, some devices like the Xiaomi Mi 9 have obviously wrong CF output, like two "L1" signals for the same GNSS.

I'd like to flag this output in the GPSTest UI - perhaps just coloring the font red would be sufficient for a first iteration.

Related to #265 - showing "dual-frequency support" label, as they'll likely share the same internal data structure.

Steps to reproduce:

Look at the CF column on the Xiaomi Mi 9

Expected behavior:

Flag obviously wrong CF output

Observed behavior:

No obvious indication that the data is wrong

Device and Android version:

Xiaomi Mi 9

Screenshots:

See https://medium.com/@papylepian/mi-9-9140f7db50da

@barbeau
Copy link
Owner Author

barbeau commented Oct 23, 2019

I've started working on logic that can support this at #355.

@barbeau barbeau modified the milestones: v3.5, v3.7 Jun 23, 2020
@barbeau barbeau modified the milestones: v3.7, v3.9 Dec 10, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 3, 2021
@barbeau barbeau removed the stale label Jun 3, 2021
@barbeau
Copy link
Owner Author

barbeau commented Jun 3, 2021

Closing this as a duplicate as it will be part of #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant