Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8.x]Fix req body mapping for array type from external module #1557

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Oct 17, 2023

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a175302) 79.64% compared to head (81a4e3a) 79.63%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1557      +/-   ##
============================================
- Coverage     79.64%   79.63%   -0.01%     
- Complexity     1768     1769       +1     
============================================
  Files           124      124              
  Lines         10082    10083       +1     
  Branches       1670     1672       +2     
============================================
  Hits           8030     8030              
  Misses         1470     1470              
- Partials        582      583       +1     
Files Coverage Δ
...pi/converter/service/OpenAPIRequestBodyMapper.java 86.34% <100.00%> (-0.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dilanSachi dilanSachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnash94 lnash94 changed the base branch from master to 1.8.x October 17, 2023 17:00
@lnash94 lnash94 changed the title Fix req body mapping for array type from external module [1.8.x]Fix req body mapping for array type from external module Oct 17, 2023
@lnash94 lnash94 merged commit 8f77adb into 1.8.x Oct 18, 2023
6 of 7 checks passed
@TharmiganK TharmiganK deleted the fix-req-body-mapping branch December 11, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openapi] Schema is not added when a record from other module is used
3 participants