Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master with 1.8.x branch #1547

Merged
merged 10 commits into from
Oct 6, 2023
Merged

Sync master with 1.8.x branch #1547

merged 10 commits into from
Oct 6, 2023

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented Sep 26, 2023

Purpose

$Subject

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (7ae3ba4) 79.61% compared to head (099183d) 79.64%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1547      +/-   ##
============================================
+ Coverage     79.61%   79.64%   +0.03%     
- Complexity     1743     1768      +25     
============================================
  Files           124      124              
  Lines          9986    10082      +96     
  Branches       1658     1670      +12     
============================================
+ Hits           7950     8030      +80     
- Misses         1456     1470      +14     
- Partials        580      582       +2     
Files Coverage Δ
...enapi/converter/diagnostic/DiagnosticMessages.java 100.00% <100.00%> (ø)
...java/io/ballerina/openapi/core/GeneratorUtils.java 88.14% <0.00%> (+0.20%) ⬆️
...enapi/converter/service/OpenAPIResourceMapper.java 73.52% <40.00%> (+0.59%) ⬆️
...pi/converter/service/OpenAPIRequestBodyMapper.java 86.72% <84.24%> (-4.32%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[1.8.x] Fix type mismatching when the resource path end with path segment including parameter and extensions
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lnash94 lnash94 merged commit a175302 into master Oct 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants