[1.8.x]Add support for union type request body mapping to Ballerina to OpenAPI spec generation #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnash94
force-pushed
the
master-1536
branch
from
d09edd1 to
b06153b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 1.8.x ballerina-platform/openapi-tools#1544 +/- ##
========================================
Coverage ? 79.55%
Complexity ? 1763
========================================
Files ? 124
Lines ? 10086
Branches ? 1673
========================================
Hits ? 8024
Misses ? 1479
Partials ? 583 ☔ View full report in Codecov by Sentry. |
lnash94
force-pushed
the
master-1536
branch
from
b06153b to
7782d75
Compare
lnash94
force-pushed
the
master-1536
branch
from
7782d75 to
deb8b15
Compare
lnash94
changed the title
dilanSachi
reviewed
Sep 21, 2023
...l-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIRequestBodyMapper.java
Outdated
Show resolved
Hide resolved
dilanSachi
reviewed
Sep 21, 2023
...l-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIRequestBodyMapper.java
Outdated
Show resolved
Hide resolved
dilanSachi
reviewed
Sep 21, 2023
...l-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIRequestBodyMapper.java
Outdated
Show resolved
Hide resolved
dilanSachi
reviewed
Sep 21, 2023
...l-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIRequestBodyMapper.java
Show resolved
Hide resolved
TharmiganK
reviewed
Sep 22, 2023
openapi-cli/src/test/resources/ballerina-to-openapi/request_body/union_type.bal
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
ayeshLK
reviewed
Sep 25, 2023
openapi-cli/src/test/resources/ballerina-to-openapi/request_body/union_type.bal
Show resolved
Hide resolved
ayeshLK
approved these changes
Sep 26, 2023
Comment on lines
+245
to
+255
| IncompatibleResourceDiagnostic error = new IncompatibleResourceDiagnostic( | ||
| DiagnosticMessages.OAS_CONVERTOR_116, payloadNode.location(), | ||
| String.valueOf(payloadNode.kind())); | ||
| diagnostics.add(error); | ||
| break; | ||
| } | ||
| } else { | ||
| //Warning message for unsupported request payload type in Ballerina resource. | ||
| IncompatibleResourceDiagnostic error = new IncompatibleResourceDiagnostic( | ||
| DiagnosticMessages.OAS_CONVERTOR_116, payloadNode.location(), payloadNode.toSourceCode().trim()); | ||
| diagnostics.add(error); |
There was a problem hiding this comment.
Here we are using the same error, but with two different properties of the payload (payload kind at L247 and, payload node itself at L254). Is that intentional?
| operationAdaptor.getOperation().setRequestBody(bodyParameter); | ||
| } | ||
| } | ||
|
|
||
| private void addConsumes(OperationAdaptor operationAdaptor, RequestBody bodyParameter, String applicationType) { | ||
| String type = applicationType.split("/")[1]; | ||
| private void addConsumes(OperationAdaptor operationAdaptor, RequestBody bodyParameter, String applicationType, |
There was a problem hiding this comment.
Whats the purpose of this util?
| content.addMediaType(mimeType, media); | ||
| } else if (typeDescriptorNode.kind() == SyntaxKind.BYTE_TYPE_DESC) { | ||
| StringSchema byteSchema = new StringSchema(); | ||
| byteSchema.setFormat("byte"); |
There was a problem hiding this comment.
Shall we reuse our predefined constant for "byte" in here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning