Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling support for OracleDB module #82

Merged
merged 12 commits into from
Nov 29, 2021

Conversation

niveathika
Copy link
Contributor

@niveathika niveathika commented Nov 27, 2021

Purpose

$subject

Fixes ballerina-platform/ballerina-library#2283

Examples

  • Validating nonzero int/float values for oracledb:Options in variable declaration and initialization,

Screenshot 2021-11-28 at 01 13 40

  • Validate fields of sql:ConnectionPool param in connector initialization,

Screenshot 2021-11-28 at 01 14 22

  • Validate supported types for get() method in OutParameters,

Screenshot 2021-11-28 at 01 20 26

  • Add hints when query() and queryRow() methods cannot infer the return type description.
  • Add hints when get() method of OutParameters cannot infer the return type description.

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@niveathika niveathika requested a review from daneshk as a code owner November 27, 2021 19:30
@codecov
Copy link

codecov bot commented Nov 27, 2021

Codecov Report

Merging #82 (6a3173a) into main (cbd75dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #82   +/-   ##
=========================================
  Coverage     84.99%   84.99%           
  Complexity      181      181           
=========================================
  Files            16       16           
  Lines           633      633           
  Branches        139      139           
=========================================
  Hits            538      538           
  Misses           52       52           
  Partials         43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd75dc...6a3173a. Read the comment docs.

@niveathika niveathika merged commit f68c63d into ballerina-platform:main Nov 29, 2021
@niveathika niveathika deleted the tooling branch December 22, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooling support for OracleDB
2 participants