Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XA transaction #467

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Conversation

niveathika
Copy link
Contributor

@niveathika niveathika commented Nov 10, 2022

Purpose

$subject

Fixes ballerina-platform/ballerina-library#3599

Examples

Enable the XA datasource using useXADatasource option

oracledb:Client dbClient = check new ("localhost", "admin", "password", "xe", 1521, options = {useXADatasource: true});

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests -> Manually tested due to a constraint in Oracle Docker
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 85.47% // Head: 85.25% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (c3b1a24) compared to base (4ade833).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #467      +/-   ##
============================================
- Coverage     85.47%   85.25%   -0.22%     
  Complexity      181      181              
============================================
  Files            16       16              
  Lines           647      651       +4     
  Branches        135      136       +1     
============================================
+ Hits            553      555       +2     
- Misses           51       52       +1     
- Partials         43       44       +1     
Impacted Files Coverage Δ
...na/stdlib/oracledb/nativeimpl/ClientProcessor.java 92.30% <33.33%> (-4.99%) ⬇️
ballerina/client.bal 100.00% <100.00%> (ø)
...n/java/io/ballerina/stdlib/oracledb/Constants.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support XA transaction in Ballerina Oracle Connector
2 participants