Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.2.x Backport] Add support for XA transaction #466

Merged
merged 5 commits into from
Nov 11, 2022

Conversation

niveathika
Copy link
Contributor

@niveathika niveathika commented Nov 10, 2022

Purpose

$subject

Master branch PR: #467
Related to ballerina-platform/ballerina-library#3642

Examples

Enable the XA datasource using useXADatasource option

oracledb:Client dbClient = check new ("localhost", "admin", "password", "xe", 1521, options = {useXADatasource: true});

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests -> Manually tested due to a constraint in Oracle Docker
  • Checked native-image compatibility

@niveathika niveathika requested a review from daneshk as a code owner November 10, 2022 19:08
@niveathika niveathika changed the title Add support for XA transaction [2201.2.x] Add support for XA transaction Nov 10, 2022
@niveathika niveathika changed the title [2201.2.x] Add support for XA transaction [2201.2.x Backport] Add support for XA transaction Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 85.38% // Head: 85.16% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (f3292d2) compared to base (f4f2fe7).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.2.x     #466      +/-   ##
==============================================
- Coverage       85.38%   85.16%   -0.22%     
  Complexity        181      181              
==============================================
  Files              16       16              
  Lines             643      647       +4     
  Branches          136      137       +1     
==============================================
+ Hits              549      551       +2     
- Misses             51       52       +1     
- Partials           43       44       +1     
Impacted Files Coverage Δ
...na/stdlib/oracledb/nativeimpl/ClientProcessor.java 92.30% <33.33%> (-4.99%) ⬇️
ballerina/client.bal 100.00% <100.00%> (ø)
...n/java/io/ballerina/stdlib/oracledb/Constants.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@niveathika niveathika merged commit 1a2e3f6 into ballerina-platform:2201.2.x Nov 11, 2022
@niveathika niveathika deleted the 2201.2.x branch November 11, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants