-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @pattern
support for constraint package
#29
Add @pattern
support for constraint package
#29
Conversation
Codecov ReportBase: 89.51% // Head: 90.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
============================================
+ Coverage 89.51% 90.11% +0.60%
- Complexity 121 126 +5
============================================
Files 17 18 +1
Lines 248 253 +5
Branches 43 43
============================================
+ Hits 222 228 +6
Misses 13 13
+ Partials 13 12 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # ballerina/Ballerina.toml # build-config/resources/Ballerina.toml # changelog.md # gradle.properties # native/src/main/java/io/ballerina/stdlib/constraint/validators/AbstractLengthValidator.java
Didn't go through the code but the functionality looks good to me! Hope @chamil321 will validate the tests and the code. Also lets make sure tooling side is ready when it comes to regex. |
...a/io/ballerina/stdlib/constraint/compiler/annotation/tag/LengthConstrainedAnnotationTag.java
Outdated
Show resolved
Hide resolved
...va/io/ballerina/stdlib/constraint/compiler/annotation/tag/ValueConstrainedAnnotationTag.java
Outdated
Show resolved
Hide resolved
There are still some pending issues regarding the tooling support for regexp from lang side such as : |
Purpose
Fixes :
Add @pattern support for constraint package #3179
Examples
Checklist