Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Create variable code action is not suggesting for "re ``" expression #39249

Closed
LakshanWeerasinghe opened this issue Jan 13, 2023 · 2 comments · Fixed by #39509
Closed
Assignees
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug userCategory/Editor

Comments

@LakshanWeerasinghe
Copy link
Contributor

Description

$subject

Screenshot 2023-01-13 at 10 21 17

Steps to Reproduce

No response

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Editor

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@LakshanWeerasinghe LakshanWeerasinghe added Type/Bug Team/LanguageServer Language Server Implementation related issues. #Compiler Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. labels Jan 13, 2023
@ballerina-bot ballerina-bot added needTriage The issue has to be inspected and labeled manually userCategory/Editor labels Jan 13, 2023
@anupama-pathirage anupama-pathirage removed the needTriage The issue has to be inspected and labeled manually label Jan 13, 2023
@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@LakshanWeerasinghe
Copy link
Contributor Author

Using the type symbol signature we use the processModuleIDsInText method to get the type signature. Since RegExp type is defined in the lang.regexp module we get regexp qualified name as the type prefix. If we are going to give string prefix when declaring RegExp type we have to special case it. So we decided to go with regexp module prefix.

public static String processModuleIDsInText(ImportsAcceptor importsAcceptor, String text,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug userCategory/Editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants