Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP] Introduce common HTTP client config to remove repetition #21275

Merged
merged 9 commits into from
Mar 2, 2020
Merged

[HTTP] Introduce common HTTP client config to remove repetition #21275

merged 9 commits into from
Mar 2, 2020

Conversation

BuddhiWathsala
Copy link
Contributor

Purpose

Fixes #21049

Approach

As mentioned in this #21049 (comment);

List the copied fields in the referencing type and say "copied from T" with a link to T

Remarks

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

daneshk
daneshk approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chamil321 chamil321 merged commit 0caa513 into ballerina-platform:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daneshk daneshk daneshk approved these changes

@chamil321 chamil321 chamil321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use type reference in [HTTP/WS] ClientConfigs
3 participants
@BuddhiWathsala @chamil321 @daneshk