Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type reference in [HTTP/WS] ClientConfigs #21049

Closed
chamil321 opened this issue Feb 13, 2020 · 2 comments · Fixed by #21275
Closed

Use type reference in [HTTP/WS] ClientConfigs #21049

chamil321 opened this issue Feb 13, 2020 · 2 comments · Fixed by #21275
Assignees
@BuddhiWathsala
Labels
Points/1 Equivalent to one day effort Team/StandardLibs All Ballerina standard libraries Type/Improvement

Comments

@chamil321
Copy link
Contributor

chamil321 commented Feb 13, 2020 •
edited
Loading

Description:

type some record {
    *SomeOtherRecord
}

Affected Versions:

OS, DB, other environment details and versions:

Related Issues (optional):
#21082

Suggested Labels (optional):

Suggested Assignees (optional):
@chamil321 chamil321 self-assigned this Feb 13, 2020
@chamil321 chamil321 added the Points/1 Equivalent to one day effort label Feb 13, 2020
@chamil321 chamil321 changed the title Use Abstraction in [HTTP/WS] ClientConfigs Use type reference in [HTTP/WS] ClientConfigs Feb 14, 2020
@chamil321
Copy link
Contributor Author

Improvement is on hold as #21082 is a prerequisite for the task

@chamil321 chamil321 added Status/Blocked and removed Points/1 Equivalent to one day effort labels Feb 14, 2020
@chamil321 chamil321 removed their assignment Feb 14, 2020
@ldclakmal ldclakmal added the Points/1 Equivalent to one day effort label Feb 20, 2020
@chamil321
Copy link
Contributor Author

As per the final comment on ballerina-platform/ballerina-spec#423, we can go ahead with the mentioned solution.

List the copied fields in the referencing type and say "copied from T" with a link to T

Approach

Introduce CommonClientConfig and refer it in the ClientConfig, "FailioverClientConfig" and wherever the place these configs are used

@BuddhiWathsala BuddhiWathsala mentioned this issue Feb 26, 2020
Merged
13 tasks
@BuddhiWathsala BuddhiWathsala mentioned this issue Mar 2, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BuddhiWathsala BuddhiWathsala

Labels
Points/1 Equivalent to one day effort Team/StandardLibs All Ballerina standard libraries Type/Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HTTP] Introduce common HTTP client config to remove repetition
3 participants
@chamil321 @ldclakmal @BuddhiWathsala