Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting CLI Tool #15664

Conversation

NipunaMarcus
Copy link
Contributor

@NipunaMarcus NipunaMarcus commented Jun 11, 2019

Purpose

This will add a CLI tool for Ballerina source formatting.

Fixes #15663
Fixes #15373
Fixes #13794

Check List

  • Read the Contributing Guide
  • Required Balo version update
  • Updated Change Log
  • Checked Tooling Support
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@kaviththiranga kaviththiranga mentioned this pull request Jun 11, 2019
32 tasks
@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #15664 into master will increase coverage by 4.04%.
The diff coverage is 13.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #15664      +/-   ##
============================================
+ Coverage     10.54%   14.59%   +4.04%     
- Complexity     3362     3701     +339     
============================================
  Files          1971     1491     -480     
  Lines         91548    75464   -16084     
  Branches      12752     9885    -2867     
============================================
+ Hits           9651    11011    +1360     
+ Misses        79913    63062   -16851     
+ Partials       1984     1391     -593
Impacted Files Coverage Δ Complexity Δ
...ang/langserver/formatting/FormattingConstants.java 50% <ø> (+50%) 1 <0> (+1) ⬆️
...rg/ballerinalang/langserver/formatting/Tokens.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rg/ballerinalang/langserver/common/CommonKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...main/java/org/ballerinalang/model/TreeBuilder.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../ballerinalang/compiler/BIRPackageSymbolEnter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ballerinalang/langserver/common/LSNodeVisitor.java 10% <0%> (+10%) 17 <0> (+17) ⬆️
...ballerinalang/compiler/desugar/ServiceDesugar.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...lang/compiler/bir/writer/BIRInstructionWriter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wso2/ballerinalang/compiler/bir/model/BIRNode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...org/ballerinalang/langserver/SnippetGenerator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 714 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee56b9...b0d7e26. Read the comment docs.

@NipunaMarcus
Copy link
Contributor Author

Closing the PR because this has to be sent to the jballerina branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet