Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Signature Help Feature in LS #15874

Merged
merged 7 commits into from
Jun 25, 2019

Conversation

rasika
Copy link
Contributor

@rasika rasika commented Jun 20, 2019

Purpose

Revamp Signature Help Feature in LS.

Fixes #4569
Fixes #15818
Fixes #12035

Now Completions also triggers the signature help provider.

signature

Check List

  • Read the Contributing Guide
  • Required Balo version update
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@rasika rasika added Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Improvement labels Jun 20, 2019
@kaviththiranga kaviththiranga mentioned this pull request Jun 21, 2019
22 tasks
@rasika rasika added this to the JBallerina 1.0.0 milestone Jun 21, 2019
@rasika rasika force-pushed the fix-15818 branch 3 times, most recently from f556054 to ad49180 Compare June 23, 2019 05:27
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (jballerina@93962c0). Click here to learn what that means.
The diff coverage is 58.03%.

Impacted file tree graph

@@              Coverage Diff              @@
##             jballerina   #15874   +/-   ##
=============================================
  Coverage              ?   14.84%           
  Complexity            ?     3763           
=============================================
  Files                 ?     1497           
  Lines                 ?    75716           
  Branches              ?     9917           
=============================================
  Hits                  ?    11242           
  Misses                ?    63064           
  Partials              ?     1410
Impacted Files Coverage Δ Complexity Δ
...ng/langserver/completions/util/CompletionUtil.java 0% <ø> (ø) 0 <0> (?)
...etions/builder/BFunctionCompletionItemBuilder.java 0% <0%> (ø) 0 <0> (?)
...nalang/langserver/sourceprune/SourcePruneKeys.java 100% <100%> (ø) 1 <0> (?)
...lang/langserver/sourceprune/LHSTokenTraverser.java 97.29% <100%> (ø) 27 <0> (?)
...lerinalang/langserver/signature/SignatureKeys.java 100% <100%> (ø) 1 <0> (?)
...ang/langserver/signature/SignatureTreeVisitor.java 82.88% <16.66%> (ø) 28 <1> (?)
...lerinalang/langserver/common/utils/CommonUtil.java 13.59% <50%> (ø) 36 <3> (?)
...nalang/langserver/signature/SignatureHelpUtil.java 62.71% <54.69%> (ø) 38 <30> (?)
...alang/langserver/BallerinaTextDocumentService.java 48.18% <69.69%> (ø) 26 <2> (?)
...erinalang/langserver/sourceprune/SourcePruner.java 83.95% <72.72%> (ø) 14 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93962c0...a652148. Read the comment docs.

Copy link
Contributor

@nadeeshaan nadeeshaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@nadeeshaan nadeeshaan merged commit 713da2e into ballerina-platform:jballerina Jun 25, 2019
@kaviththiranga kaviththiranga mentioned this pull request Jun 25, 2019
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants