Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA workflows for each device type #530
Add GHA workflows for each device type #530
Changes from all commits
0c996a5
d45d564
f41e8aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we pin the action to balena-os/balena-yocto-scripts#412 and add secureboot to this matrix to test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, some other things need to happen first:
Essentially I don't want to merge Anton's encryption PR without testing it with either private device types or secure boot device types. Unfortunately all of those devices are currently not building without the meta balena change, and cannot be allowed to merge without the yocto-scripts finalize fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I could combine 2 + 3 into one PR to make testing easier, but until we get a new meta-balena version we are still kinda blocked. I can manually update meta-balena in this PR to the unmerged branch I guess...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually bumped meta-balena here, since it's only for testing anyway and not merging.
If artifact encryption looks good on that PR, I can merge the feature and unblock ourselves further.