Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds for host distributions that use glibc-2.39 and gcc 13 - like Ubuntu 24.04 #3517

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

alexgg
Copy link
Contributor

@alexgg alexgg commented Sep 16, 2024


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 16, 2024 13:32 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com September 20, 2024 12:44 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com September 20, 2024 12:44 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 20, 2024 12:52 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 20, 2024 12:52 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 20, 2024 12:52 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 20, 2024 12:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 20, 2024 13:39 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 20, 2024 15:30 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com September 20, 2024 15:30 — with GitHub Actions Inactive
@klutchell
Copy link
Collaborator

LGTM

@alexgg alexgg temporarily deployed to balena-staging.com September 20, 2024 19:50 — with GitHub Actions Inactive
@flowzone-app flowzone-app bot merged commit a39a91a into master Sep 20, 2024
167 of 171 checks passed
@flowzone-app flowzone-app bot deleted the alexgg/glibc-2.39-gcc-13 branch September 20, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants