Run pre-built Docker image #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
reviewed
Aug 22, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I found the same thing when I tried it @ab77 but I didn't investigate further |
ab77
force-pushed
the
ab77/operational
branch
from
c542daa to
3ebea61
Compare
ab77
force-pushed
the
ab77/operational
branch
from
3ebea61 to
4833290
Compare
ab77
force-pushed
the
ab77/operational
branch
5 times, most recently
from
316a89e to
d326a4d
Compare
Page-
reviewed
Oct 11, 2022
Co-authored-by: Page- <[email protected]> Change-type: patch
ab77
force-pushed
the
ab77/operational
branch
from
ee862cb to
e8769e2
Compare
|
@balena-ci I self-certify! |
ghost
merged commit 
ghost
approved these changes
Oct 11, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we are already publishing a Docker image to gh.cr, it makes sense to tell the action to use that, rather than building it from a
Dockerfileon every execution. At least this PR makes this possible, if I understoodaction.ymlspec correctly.Tests:
(build) ~ 56s: https://github.com/belodetek/black.box/runs/7940470251?check_suite_focus=true
(pull) ~ 12s: https://github.com/belodetek/black.box/runs/7940905781?check_suite_focus=true
cc @klutchell @20k-ultra