Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish action image to public registry #27

Closed
20k-ultra opened this issue Oct 28, 2021 · 13 comments
Closed

Publish action image to public registry #27

20k-ultra opened this issue Oct 28, 2021 · 13 comments

Comments

@20k-ultra
Copy link
Contributor

If we publish a built image of the action then we can reference that in workflows which would save the entire build time. This will speed up the action significantly.

https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-using-a-docker-hub-action

@20k-ultra
Copy link
Contributor Author

After we publish images to public registry we should update the README to mention using the image.

@klutchell
Copy link
Collaborator

We should attempt to use the balena registry and an open fleet for this once we add support for vanity image names.
More to come.

@20k-ultra
Copy link
Contributor Author

Can you elaborate on the open fleet part ? I like the idea of using balena registry as long as the image path is recognizable and not random strings. People have to add this url to their workflow so if it's random strings then the UX seems worse compared to a recognizable location.

@klutchell
Copy link
Collaborator

https://jel.ly.fish/milestone-block-images-balena-registry-4ef9934

It's a blocks milestone for now, but it impacts any project we would normally put in DH.

We want to host balenaBlock images in the balena registry, but have human-readable references for users to add to their docker-compose file.

tl;dr we are looking at adding a pre-pull hook to our registry to translate names to full image paths.

@klutchell
Copy link
Collaborator

klutchell commented Mar 24, 2022

Now that the proxy has shipped we should push this project to a fleet (via deploy-to-balena action of course) and have users pull the image at runtime to save compiling.

      - uses: bh.cr/balena/[email protected]
        id: build
        with:
          balena_token: ${{ secrets.BALENA_TOKEN }}
          fleet: my_org/sample_fleet

@20k-ultra
Copy link
Contributor Author

I'd rather push to Github's registry tbh because I don't want to maintain the fleet on balenacloud

@klutchell
Copy link
Collaborator

because I don't want to maintain the fleet on balenacloud

this is concerning on many levels

@ab77
Copy link
Contributor

ab77 commented Aug 20, 2022

because I don't want to maintain the fleet on balenacloud

this is concerning on many levels

Indeed. To resolve this issue (correctly), we first need to publish this code as a block on balenaHub. Once it's there, we can reference it in GitHub actions worflows using normal docker run syntax, straight from bh.cr/.

@20k-ultra
Copy link
Contributor Author

It seems like really unnecessary dogfooding. Just build the image and push it to ghcr.

The outcome seems the same with extra steps if we push to bh.cr.

@20k-ultra
Copy link
Contributor Author

The action is pushing to gchr since 411241f

@klutchell
Copy link
Collaborator

The action is pushing to gchr since 411241f

How do we use it though? I tried calling the docker image from my workflow and it can't find the inputs.

@klutchell
Copy link
Collaborator

This PR might help #195

@20k-ultra
Copy link
Contributor Author

20k-ultra commented Aug 26, 2022

The action is pushing to gchr since 411241f

How do we use it though? I tried calling the docker image from my workflow and it can't find the inputs.

check out https://github.com/20k-ultra/action-tester/actions/runs/2116842116/workflow#L18-L25

Doing so however revealed #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants