switch to c8 for code coverage #6778
Merged
+241
−894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
added
developer-experience
|
calebcartwright
commented
Jul 18, 2021
| @@ -68,16 +68,16 @@ | |||
| "xpath": "~0.0.32" | |||
| }, | |||
| "scripts": { | |||
| "coverage:test:core": "nyc npm run test:core", | |||
| "coverage:test:frontend": "nyc --nycrc-path .nycrc-frontend.json npm run test:frontend", | |||
There was a problem hiding this comment.
c8 defines its own config files (e.g. .c8rc.json) but it will happily accept the nyc-named files as well. For the moment I've opted to not rename these files because it's not necessary and because I figure it makes sense to try c8 for a while before fully committing
calebcartwright
commented
Jul 18, 2021
| "coverage:test:package": "c8 npm run test:package", | ||
| "coverage:test:entrypoint": "c8 npm run test:entrypoint", | ||
| "coverage:test:integration": "c8 npm run test:integration", | ||
| "coverage:test:services": "c8 npm run test:services", | ||
| "coverage:clean": "rimraf .nyc_output coverage", |
There was a problem hiding this comment.
Same theme here relative to a trial period for c8. Plus this directory will likely already exist on the local fs for regular contributors so doesn't hurt to keep it in here for a little while regardless
|
Thanks for picking this up! |
paulmelnikow
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6753