Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update c8 configuration #10361

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Update c8 configuration #10361

merged 2 commits into from
Jul 13, 2024

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Jul 12, 2024

@PyvesB PyvesB added the developer-experience Dev tooling, test framework, and CI label Jul 12, 2024
Copy link
Contributor

github-actions bot commented Jul 12, 2024

Warnings
⚠️

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 5462245

@chris48s
Copy link
Member

We could also remove this from gitignore:

shields/.gitignore

Lines 53 to 54 in 848e409

# nyc test coverage
.nyc_output

chris48s
chris48s previously approved these changes Jul 13, 2024
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pointed out one more thing we can remove, but it doesn't need another round of review after that. Feel free to just bypass branch protections to merge

@PyvesB
Copy link
Member Author

PyvesB commented Jul 13, 2024

Yeah, I wasn't sure whether to keep it or not as it was added in bulk with other stuff in 7c4b2b6, but happy to remove it!

@PyvesB PyvesB merged commit 6b0b88d into badges:master Jul 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants