Support Snap CI #492
Support Snap CI #492
Conversation
|
Thanks for contributing! I'm not a big fan of SVG scraping, as changing the image asset can break this, so if you can improve on this by asking Snap CI to provide an API, it would be great! Just to be clear, I will merge this once you've answered the review. |
| sendBadge(format, badgeData); | ||
| return; | ||
| } | ||
| console.log(badgeData.text[1]); |
There was a problem hiding this comment.
I think this is a leftover from debugging. Can you remove it?
There was a problem hiding this comment.
oh... This is debug code. I should remove it.
|
Thanks review! I'll fix these problem point.
Exactly, I looked for Snap CI API but not found. I want to use Snap CI API too! |
|
@espadrine Fix indicated points by PR. Thanks! |
| } else if (res === 'Failed') { | ||
| badgeData.colorscheme = 'red'; | ||
| } else { | ||
| badgeData.text[1] = res.toLowerCase(); |
There was a problem hiding this comment.
I believe this operation does not change the content of badgeData.text[1], as it was already set to the lowercase version of res. Am I wrong?
If I am correct, could you remove the else clause please?
There was a problem hiding this comment.
Thanks. I think so too.
|
@espadrine Fix indicated points, and merged upstream/master. Thanks! |
|
Thanks a lot for contributing! |
|
Thanks!! |
Hi. I've implemented #471.
Snap CI is
https://snap-ci.com
Thanks.