Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snap CI build status support #471

Closed
tjrana opened this issue Jun 10, 2015 · 7 comments
Closed

Add Snap CI build status support #471

tjrana opened this issue Jun 10, 2015 · 7 comments
Labels
service-badge New or updated service badge

Comments

@tjrana
Copy link

tjrana commented Jun 10, 2015

I would like to suggest that Snap CI can also be integrated into this badges/shields project.

@tjrana tjrana changed the title Snap CI build status badge Snap CI build status badge support Jun 10, 2015
@tjrana tjrana changed the title Snap CI build status badge support Add Snap CI build status support Jun 10, 2015
@espadrine
Copy link
Member

Thanks for the suggestion!

@ghost
Copy link

ghost commented Jul 1, 2015

👍

1 similar comment
@pine
Copy link
Contributor

pine commented Jul 17, 2015

👍

@pine pine mentioned this issue Jul 17, 2015
@kentcdodds
Copy link

Thanks @pine613! Any way we could get support for private repos as well? This would effectively turn this line

var url = 'https://snap-ci.com/' + userRepo + '/branch/' + branch + '/build_image.svg';

into this:

var url = 'https://snap-ci.com/' + repoToken + '/build_image.svg';

I'm not 100% certain that I know what needs to change though...

@espadrine
Copy link
Member

@kentcdodds Thanks for indicating this! I assume repoToken is meant to be secret, which makes testing awkward. Copying the same Snap CI code in shields under a different URL (say, /snap-ci/private/TOKEN.svg) ought to work?

I made a bit of a mistake during the review by not requiring /snap-ci/ci/user/repo.svg, but I hope it won't hurt too much in the future.

@kentcdodds
Copy link

Unfortunately snap-ci/private/TOKEN.svg doesn't currently work (were you saying that it would?)

@espadrine
Copy link
Member

It doesn't, but it is a plausible Shields URL if it were to be implemented.

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Apr 18, 2017
@tjrana tjrana closed this as completed Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

No branches or pull requests

5 participants