-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snap CI build status support #471
Comments
Thanks for the suggestion! |
👍 |
1 similar comment
👍 |
Thanks @pine613! Any way we could get support for private repos as well? This would effectively turn this line var url = 'https://snap-ci.com/' + userRepo + '/branch/' + branch + '/build_image.svg'; into this: var url = 'https://snap-ci.com/' + repoToken + '/build_image.svg'; I'm not 100% certain that I know what needs to change though... |
@kentcdodds Thanks for indicating this! I assume repoToken is meant to be secret, which makes testing awkward. Copying the same Snap CI code in shields under a different URL (say, I made a bit of a mistake during the review by not requiring |
Unfortunately |
It doesn't, but it is a plausible Shields URL if it were to be implemented. |
I would like to suggest that Snap CI can also be integrated into this badges/shields project.
The text was updated successfully, but these errors were encountered: