Fixed [Codacy] coverage examples and improved unknown coverage handling #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyvesB
added
bug
Generated by 🚫 dangerJS |
Closed
chris48s
reviewed
Sep 19, 2018
| badgeData.text[1] = res | ||
| badgeData.colorscheme = coveragePercentageColor(parseInt(res)) | ||
| const coverage = parseInt(res) | ||
| if (isNaN(coverage)) { |
There was a problem hiding this comment.
This might be a case where it is better to use Number.isNaN() in preference to isNaN()
chris48s
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project used on the homepage doesn't have any relevant coverage data:
I've switched it to one that does:
As you can see above the unknown coverage case is handled pretty poorly, with the exclamation mark and the bright green colour. From now on, such a badge would render as: