Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codacy badges broken #1985

Closed
PyvesB opened this issue Aug 27, 2018 · 5 comments
Closed

Codacy badges broken #1985

PyvesB opened this issue Aug 27, 2018 · 5 comments
Assignees
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge

Comments

@PyvesB
Copy link
Member

PyvesB commented Aug 27, 2018

Codacy have updated their own badges and we are no longer able to retrieve any relevant information using our fetchFromSvg function. As our result, Shields's badges are no longer working properly:


They do have a proper API documented here, but an API token is required. When none is provided, requests are rejected, even for public projects:

{"error":"not found"}

We may need to contact support to get this sorted.

@PyvesB PyvesB added needs-upstream-help Not actionable without help from a service provider bug Bugs in badges and the frontend service-badge New or updated service badge labels Aug 27, 2018
@nemchik
Copy link

nemchik commented Aug 28, 2018

I have reached out to Codacy support to make them aware of the issue. I will report back with any relevant responses.

nemchik added a commit to GhostWriters/DockSTARTer that referenced this issue Aug 28, 2018
The Travis badge was not pointing to the master branch so any failure on any branch would make the badge in the readme show a build failure. The Codacy badge from shields.io is currently broken badges/shields#1985 I have commented it to hide for now as well as pointed it to the master branch for when it is fixed.
gluons added a commit to gluons/vue-up that referenced this issue Sep 2, 2018
Current Shields' badge is broken. See badges/shields#1985
josh146 added a commit to XanaduAI/strawberryfields that referenced this issue Sep 4, 2018
@nemchik
Copy link

nemchik commented Sep 5, 2018

Received a response from Codacy support. They have added the information required back into the badges. It seems like previously they only included two text fields in the SVG but now they include 3, so the index of the field needed for shields has increased by one for both badges.

@PyvesB
Copy link
Member Author

PyvesB commented Sep 5, 2018

This is great, thanks for keeping us updated!

The way forward is probably something along these lines:

  • add tests to our Codacy service implementation. This will allow us to maintain it more easily in the future.
  • extend fetchFromSvg to allow specifying a match index other than 1.
  • make sure we keep an eye on [WIP] Rewrite [vso] badges #2031 to avoid any clashes with the ongoing work around some other SVG services.

I'm happy to look into this over the week-end, but if someone wants to help out and submit a pull request before that, please feel free to do so (simply make some noise here so that we don't both start working on the same thing). 😉

@PyvesB PyvesB removed the needs-upstream-help Not actionable without help from a service provider label Sep 5, 2018
@PyvesB PyvesB self-assigned this Sep 8, 2018
@PyvesB
Copy link
Member Author

PyvesB commented Sep 10, 2018

Okay, a proposed fix has now been merged into the master branch and will likely be deployed in the coming days. 👍

@PyvesB
Copy link
Member Author

PyvesB commented Sep 19, 2018

All good, we are live since yesterday:

We're doing some more work to further improve the user experience with our Codacy badges, see #2102 for more information. 😉

@PyvesB PyvesB closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Development

No branches or pull requests

2 participants