Focus "Name" in PatchStore Dialog when opened (surge-synthesizer#5227)

You have to do this on the event *after* the name editor is showing so in the parent heirarchy changed callbacks.
baconpaul · Oct 7, 2021 · 9d60a0f · 9d60a0f
1 parent 5ced8f7
commit 9d60a0f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/surge-xt/gui/overlays/PatchStoreDialog.cpp b/src/surge-xt/gui/overlays/PatchStoreDialog.cpp
@@ -90,7 +90,6 @@ PatchStoreDialog::PatchStoreDialog()
         auto ed = std::make_unique<juce::TextEditor>(n);
         ed->setJustification(juce::Justification::centredLeft);
         ed->setWantsKeyboardFocus(true);
-        ed->grabKeyboardFocus();
 
         addAndMakeVisible(*ed);
         return std::move(ed);
@@ -178,6 +177,12 @@ void PatchStoreDialog::setSurgeGUIEditor(SurgeGUIEditor *e)
     }
 }
 
+void PatchStoreDialog::parentHierarchyChanged()
+{
+    if (nameEd->isShowing() && isVisible())
+        nameEd->grabKeyboardFocus();
+}
+
 void PatchStoreDialog::onSkinChanged()
 {
     auto resetColors = [this](const auto &typein) {

diff --git a/src/surge-xt/gui/overlays/PatchStoreDialog.h b/src/surge-xt/gui/overlays/PatchStoreDialog.h
@@ -39,6 +39,7 @@ struct PatchStoreDialog : public OverlayComponent,
     ~PatchStoreDialog();
     void paint(juce::Graphics &g) override;
     void resized() override;
+    void parentHierarchyChanged() override;
 
     SurgeGUIEditor *editor{nullptr};
     void setSurgeGUIEditor(SurgeGUIEditor *e);