Favorites didn't survive a refresh (surge-synthesizer#5226)

NOw they do
baconpaul · Oct 7, 2021 · 5ced8f7 · 5ced8f7
1 parent f13072e
commit 5ced8f7
Showing 1 changed file with 15 additions and 14 deletions.
diff --git a/src/common/SurgeStorage.cpp b/src/common/SurgeStorage.cpp
@@ -428,20 +428,6 @@ SurgeStorage::SurgeStorage(std::string suppliedDataPath) : otherscene_clients(0)
     {
         refresh_wtlist();
         refresh_patchlist();
-        auto favorites = patchDB->readUserFavorites();
-        std::unordered_set<std::string> favSet;
-        for (auto f : favorites)
-        {
-            favSet.insert(f);
-        }
-        for (auto &p : patch_list)
-        {
-            auto ps = p.path.u8string();
-            if (favSet.find(ps) != favSet.end())
-                p.isFavorite = true;
-            else
-                p.isFavorite = false;
-        }
     }
 
     getPatch().scene[0].osc[0].wt.dt = 1.0f / 512.f;
@@ -733,6 +719,21 @@ void SurgeStorage::refresh_patchlist()
     {
         patch_category[patchCategoryOrdering[i]].order = i;
     }
+
+    auto favorites = patchDB->readUserFavorites();
+    std::unordered_set<std::string> favSet;
+    for (auto f : favorites)
+    {
+        favSet.insert(f);
+    }
+    for (auto &p : patch_list)
+    {
+        auto ps = p.path.u8string();
+        if (favSet.find(ps) != favSet.end())
+            p.isFavorite = true;
+        else
+            p.isFavorite = false;
+    }
 }
 
 void SurgeStorage::refreshPatchlistAddDir(bool userDir, string subdir)