Avoid dumping COLLATE default for const clause #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surendravishnoi
approved these changes
Feb 7, 2023
Deepesh125
added a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
Feb 7, 2023
Previously, During v2.3.0 release, we fixed the most of collatable data types such as varchar to have the correct default collation same as server_collation_name. This fix may lead to dump extra COLLATE "default" clause for const clause during upgrade from 14.x to 15.1 if server is upgrade to 14.6 via minor version upgrade first. To fix this, we have introduced new hook handle_const_collation_hook on engine side and it would be initialised to print_const_collation inside babelfishpg_common extension which would determine if COLLATE needs to be dumped or not for given const clause. Task: BABEL-3895 Engine PR - babelfish-for-postgresql/postgresql_modified_for_babelfish#96 Signed-off-by: Dipesh Dhameliya <[email protected]>
Deepesh125
referenced
this pull request
in amazon-aurora/postgresql_modified_for_babelfish
Feb 7, 2023
Previously, During v2.3.0 release, we fixed the most of collatable data types such as varchar to have the correct default collation same as server_collation_name. This fix may lead to dump extra COLLATE "default" clause for const clause during upgrade from 14.x to 15.1 if server is upgrade to 14.6 via minor version upgrade first. This commit fixes that issue by determining whether COLLATE needs to be dumped or not via newly introduced hook handle_const_collation_hook_type which would be initialised by babelfishpg_common extension. Task: BABEL-3895 Signed-off-by: Dipesh Dhameliya <[email protected]>
Deepesh125
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Feb 7, 2023
Previously, During v2.3.0 release, we fixed the most of collatable data types such as varchar to have the correct default collation same as server_collation_name. This fix may lead to dump extra COLLATE "default" clause for const clause during upgrade from 14.x to 15.1 if server is upgrade to 14.6 via minor version upgrade first. To fix this, we have introduced new hook handle_const_collation_hook on engine side and it would be initialised to print_const_collation inside babelfishpg_common extension which would determine if COLLATE needs to be dumped or not for given const clause. Task: BABEL-3895 Engine PR - babelfish-for-postgresql/postgresql_modified_for_babelfish#96 Signed-off-by: Dipesh Dhameliya <[email protected]>
Merged
1 task
Deepesh125
added a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
Feb 7, 2023
Previously, During v2.3.0 release, we fixed the most of collatable data types such as varchar to have the correct default collation same as server_collation_name. This fix may lead to dump extra COLLATE "default" clause for const clause during upgrade from 14.x to 15.1 if server is upgrade to 14.6 via minor version upgrade first. To fix this, we have introduced new hook handle_const_collation_hook on engine side and it would be initialised to print_const_collation inside babelfishpg_common extension which would determine if COLLATE needs to be dumped or not for given const clause. Task: BABEL-3895 Engine PR - babelfish-for-postgresql/postgresql_modified_for_babelfish#96 Signed-off-by: Dipesh Dhameliya <[email protected]>
Deepesh125
added a commit
that referenced
this pull request
Feb 8, 2023
…t value of column and ignore explicit COLLATE default on view def in dump (#70)" (#97) This reverts commit e16b166. This commit reverts short term fix made for BABEL-3801 via #70 except the change related to data type _CI_SYSNAME as it would be required for long term fix. Long term fix for BABEL-3801 is introduced in BABEL_2_X_DEV__PG_14_X through engine PR: #96 and extension PR: babelfish-for-postgresql/babelfish_extensions#1222 Task: BABEL-3895 Signed-off-by: Dipesh Dhameliya <[email protected]>
jadewang-db
pushed a commit
to jadewang-db/postgresql_modified_for_babelfish
that referenced
this pull request
Mar 17, 2023
…belfish-for-postgresql#96) Previously, SELECT TOP (NULL) returned all rows. This commit makes it throw an error instead by adding a NULL-check in the execution of LIMIT node, and also in the planner because the planner by default skips building a LIMIT node if the LIMIT count is NULL. Task: BABEL-1181 Author: Zitao Quan <[email protected]> Signed-off-by: Sharu Goel <[email protected]> Co-authored-by: Sharu Goel <[email protected]>
xhfanhe
referenced
this pull request
in amazon-aurora/postgresql_modified_for_babelfish
Aug 11, 2023
… (#25) Previously, SELECT TOP (NULL) returned all rows. This commit makes it throw an error instead by adding a NULL-check in the execution of LIMIT node, and also in the planner because the planner by default skips building a LIMIT node if the LIMIT count is NULL. Task: BABEL-1181 Author: Zitao Quan <[email protected]> Signed-off-by: Sharu Goel <[email protected]> Co-authored-by: Sharu Goel <[email protected]> Co-authored-by: jusjosj <[email protected]> Co-authored-by: Sharu Goel <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 16, 2023
…t value of column and ignore explicit COLLATE default on view def in dump (#70)" (#97) This reverts commit e16b166. This commit reverts short term fix made for BABEL-3801 via babelfish-for-postgresql#70 except the change related to data type _CI_SYSNAME as it would be required for long term fix. Long term fix for BABEL-3801 is introduced in BABEL_2_X_DEV__PG_14_X through engine PR: babelfish-for-postgresql#96 and extension PR: babelfish-for-postgresql/babelfish_extensions#1222 Task: BABEL-3895 Signed-off-by: Dipesh Dhameliya <[email protected]>
priyansx
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 22, 2023
…t value of column and ignore explicit COLLATE default on view def in dump (#70)" (#97) This reverts commit e16b166. This commit reverts short term fix made for BABEL-3801 via babelfish-for-postgresql#70 except the change related to data type _CI_SYSNAME as it would be required for long term fix. Long term fix for BABEL-3801 is introduced in BABEL_2_X_DEV__PG_14_X through engine PR: babelfish-for-postgresql#96 and extension PR: babelfish-for-postgresql/babelfish_extensions#1222 Task: BABEL-3895 Signed-off-by: Dipesh Dhameliya <[email protected]>
tanscorpio7
added a commit
to tanscorpio7/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 31, 2024
… (babelfish-for-postgresql#96) ### Description See babelfish-for-postgresql#447 Handle bbf dump restore changes for babelfish db_accessadmin fixed database role. #### Engine PR: babelfish-for-postgresql#447 #### Extension PR: babelfish-for-postgresql/babelfish_extensions#2970 ### Issues Resolved [List any issues this PR will resolve] ### Check List - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).
abhinab-yb
pushed a commit
to abhinab-yb/yugabyte-db
that referenced
this pull request
Nov 14, 2024
…t value of column and ignore explicit COLLATE default on view def in dump (yugabyte#70)" (yugabyte#97) This reverts commit e16b166a9c40cdac44ce9cbba685dacce0443e25. This commit reverts short term fix made for BABEL-3801 via babelfish-for-postgresql/postgresql_modified_for_babelfish#70 except the change related to data type _CI_SYSNAME as it would be required for long term fix. Long term fix for BABEL-3801 is introduced in BABEL_2_X_DEV__PG_14_X through engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#96 and extension PR: babelfish-for-postgresql/babelfish_extensions#1222 Task: BABEL-3895 Signed-off-by: Dipesh Dhameliya <[email protected]>
shardgupta
pushed a commit
that referenced
this pull request
Nov 18, 2024
### Description See #447 Handle bbf dump restore changes for babelfish db_accessadmin fixed database role. #### Engine PR: #447 #### Extension PR: babelfish-for-postgresql/babelfish_extensions#2970 ### Issues Resolved [List any issues this PR will resolve] ### Check List - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).
shardgupta
pushed a commit
that referenced
this pull request
Dec 11, 2024
### Description See #447 Handle bbf dump restore changes for babelfish db_accessadmin fixed database role. #### Engine PR: #447 #### Extension PR: babelfish-for-postgresql/babelfish_extensions#2970 ### Issues Resolved [List any issues this PR will resolve] ### Check List - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, During v2.3.0 release, we fixed the most of collatable data types such as varchar to have the correct default collation same as server_collation_name. This fix may lead to dump extra COLLATE "default" clause for const clause during upgrade from 14.x to 15.1 if server is upgrade to 14.6 via minor version upgrade first.
This commit fixes that issue by determining whether COLLATE needs to be dumped or not via newly introduced hook handle_const_collation_hook_type which would be initialised by babelfishpg_common extension.
Issues Resolved
Task: BABEL-3895
Signed-off-by: Dipesh Dhameliya [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.