BABEL: Added support for ISJSON(), JSON_VALUE(), and JSON_QUERY() #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for three TSQL functions: ISJSON(), JSON_VALUE(), and JSON_QUERY(). This commit uses the sql_dialect hook to toggle logic in a few common json string processing functions, in addition to adding a binary search algorithm which selects matching json keys in the event of duplicate keys at the same level. Task: BABEL-934/935/936 Author: Brent Sienko <[email protected]> Signed-off-by: Sharu Goel <[email protected]> (cherry picked from commit fad820d)
Signed-off-by: Rishabh Tanwar <[email protected]>
xhfanhe
pushed a commit
that referenced
this pull request
Aug 11, 2023
… (#25) Previously, SELECT TOP (NULL) returned all rows. This commit makes it throw an error instead by adding a NULL-check in the execution of LIMIT node, and also in the planner because the planner by default skips building a LIMIT node if the LIMIT count is NULL. Task: BABEL-1181 Author: Zitao Quan <[email protected]> Signed-off-by: Sharu Goel <[email protected]> Co-authored-by: Sharu Goel <[email protected]> Co-authored-by: jusjosj <[email protected]> Co-authored-by: Sharu Goel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces support for three TSQL functions: ISJSON(), JSON_VALUE(), and JSON_QUERY().
This commit uses the sql_dialect hook to toggle logic in a few common json string processing functions, in addition to adding a binary search algorithm which selects matching json keys in the event of duplicate keys at the same level.
Task: BABEL-934/935/936
Author: Brent Sienko [email protected]
Signed-off-by: Sharu Goel [email protected]
(cherry picked from commit fad820d)