Fix for Order by issue in select into statement with identity function #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This commit removes unwanted fields identityName, identityType and related hook Task: BABEL-4388 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-4388 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-4388 Signed-off-by: Deepakshi Mittal <[email protected]>
deepakshi-mittal
force-pushed
the
BABEL-4388
branch
from
8494ff5 to
3ccfb87
Compare
deepakshi-mittal
changed the title
forestkeeper
reviewed
Nov 7, 2023
Task: BABEL-4388 Signed-off-by: Deepakshi Mittal <[email protected]>
xhfanhe
approved these changes
Nov 8, 2023
forestkeeper
merged commit 07b6b40
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
2 checks passed
forestkeeper
pushed a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
Nov 8, 2023
#1967) Modified transformSelectIntoStmt, remove unused variable queryString Modified SortClause and Distinct Clause of select into, removed identity function if exists in it Added alter table add identity statement which will be executed after select into statement Added IsA check for SortGroupClause Removed unused variable tsql_select_into_seq_oid Removed smallint and int functions, Dropped function objects from upgrade scripts Used strcasecmp inplace of strncasecmp Added test cases for select into identity with top clause distinct clause order by clause Engine Pr:babelfish-for-postgresql/postgresql_modified_for_babelfish#247 Task: BABEL-4388, BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 16, 2023
babelfish-for-postgresql#247) Modified transformSelectIntoStmt, remove unused variable queryString Modified SortClause and Distinct Clause of select into, removed identity function if exists in it Added alter table add identity statement which will be executed after select into statement Added IsA check for SortGroupClause Removed unused variable tsql_select_into_seq_oid Removed smallint and int functions, Dropped function objects from upgrade scripts Used strcasecmp inplace of strncasecmp Added test cases for select into identity with top clause distinct clause order by clause Engine Pr:babelfish-for-postgresql#247 Task: BABEL-4388, BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 17, 2023
babelfish-for-postgresql#247) Modified transformSelectIntoStmt, remove unused variable queryString Modified SortClause and Distinct Clause of select into, removed identity function if exists in it Added alter table add identity statement which will be executed after select into statement Added IsA check for SortGroupClause Removed unused variable tsql_select_into_seq_oid Removed smallint and int functions, Dropped function objects from upgrade scripts Used strcasecmp inplace of strncasecmp Added test cases for select into identity with top clause distinct clause order by clause Engine Pr:babelfish-for-postgresql#247 Task: BABEL-4388, BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
priyansx
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 22, 2023
babelfish-for-postgresql#247) Modified transformSelectIntoStmt, remove unused variable queryString Modified SortClause and Distinct Clause of select into, removed identity function if exists in it Added alter table add identity statement which will be executed after select into statement Added IsA check for SortGroupClause Removed unused variable tsql_select_into_seq_oid Removed smallint and int functions, Dropped function objects from upgrade scripts Used strcasecmp inplace of strncasecmp Added test cases for select into identity with top clause distinct clause order by clause Engine Pr:babelfish-for-postgresql#247 Task: BABEL-4388, BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes unwanted fields identityName, identityType and related hook
Added hook to move identity function at the end of target list
Task: BABEL-4388
Description
Reverted
Issues Resolved
BABEL-4388
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.