Fix for Order by issue in select into statement with identity function (

babelfish-for-postgresql#247)


Modified transformSelectIntoStmt, remove unused variable queryString
Modified SortClause and Distinct Clause of select into, removed identity function if exists in it
Added alter table add identity statement which will be executed after select into statement
Added IsA check for SortGroupClause
Removed unused variable tsql_select_into_seq_oid
Removed smallint and int functions,
Dropped function objects from upgrade scripts
Used strcasecmp inplace of strncasecmp

Added test cases for select into identity with

top clause
distinct clause
order by clause

Engine Pr:babelfish-for-postgresql#247

Task: BABEL-4388, BABEL-539
Signed-off-by: Deepakshi Mittal <[email protected]>

src/backend/commands/createas.c

@@ -42,19 +42,15 @@
 #include "nodes/makefuncs.h"
 #include "nodes/nodeFuncs.h"
 #include "parser/parse_clause.h"
-#include "parser/parser.h"
 #include "rewrite/rewriteHandler.h"
 #include "storage/smgr.h"
 #include "tcop/tcopprot.h"
-#include "tcop/utility.h"
 #include "utils/builtins.h"
 #include "utils/lsyscache.h"
 #include "utils/rel.h"
 #include "utils/rls.h"
 #include "utils/snapmgr.h"
 
-bbfSelectIntoAddIdentity_hook_type bbfSelectIntoAddIdentity_hook = NULL;
-
 typedef struct
 {
 	DestReceiver pub;			/* publicly-known function pointers */
@@ -114,11 +110,6 @@ create_ctas_internal(List *attrList, IntoClause *into)
 	create->if_not_exists = false;
 	create->accessMethod = into->accessMethod;
 
-	if (sql_dialect == SQL_DIALECT_TSQL)
-	{
-		if(into->identityName && bbfSelectIntoAddIdentity_hook)
-			(*bbfSelectIntoAddIdentity_hook)(into, create->tableElts);
-	}
 	/*
 	 * Create the relation.  (This will error out if there's an existing view,
 	 * so we don't need more code to complain if "replace" is false.)

src/backend/nodes/copyfuncs.c

@@ -1435,8 +1435,6 @@ _copyIntoClause(const IntoClause *from)
 	COPY_STRING_FIELD(tableSpaceName);
 	COPY_NODE_FIELD(viewQuery);
 	COPY_SCALAR_FIELD(skipData);
-	COPY_STRING_FIELD(identityName);
-	COPY_STRING_FIELD(identityType);
 
 	return newnode;
 }

src/backend/nodes/equalfuncs.c

@@ -212,8 +212,6 @@ _equalIntoClause(const IntoClause *a, const IntoClause *b)
 	COMPARE_STRING_FIELD(tableSpaceName);
 	COMPARE_NODE_FIELD(viewQuery);
 	COMPARE_SCALAR_FIELD(skipData);
-	COMPARE_STRING_FIELD(identityName);
-	COMPARE_STRING_FIELD(identityType);
 
 	return true;
 }

src/backend/nodes/outfuncs.c

@@ -1134,8 +1134,6 @@ _outIntoClause(StringInfo str, const IntoClause *node)
 	WRITE_STRING_FIELD(tableSpaceName);
 	WRITE_NODE_FIELD(viewQuery);
 	WRITE_BOOL_FIELD(skipData);
-	WRITE_STRING_FIELD(identityName);
-	WRITE_STRING_FIELD(identityType);
 }
 
 static void

src/backend/nodes/readfuncs.c

@@ -605,8 +605,6 @@ _readIntoClause(void)
 	READ_STRING_FIELD(tableSpaceName);
 	READ_NODE_FIELD(viewQuery);
 	READ_BOOL_FIELD(skipData);
-	READ_STRING_FIELD(identityName);
-	READ_STRING_FIELD(identityType);
 
 	READ_DONE();
 }

src/include/nodes/primnodes.h

@@ -126,8 +126,6 @@ typedef struct IntoClause
 	char	   *tableSpaceName; /* table space to use, or NULL */
 	Node	   *viewQuery;		/* materialized view's SELECT query */
 	bool		skipData;		/* true for WITH NO DATA */
-	char       *identityName;	/* resname for Identity Column*/
-	char       *identityType; 	/* pg type for Identity Column*/
 } IntoClause;
 
 

src/include/tcop/utility.h

@@ -115,7 +115,4 @@ typedef void (*bbfSelectIntoUtility_hook_type)(struct ParseState *pstate, Planne
 						  ParamListInfo params, QueryCompletion *qc);
 extern PGDLLIMPORT bbfSelectIntoUtility_hook_type bbfSelectIntoUtility_hook;
 
-typedef void (*bbfSelectIntoAddIdentity_hook_type)(IntoClause *into, List *tableElts);
-extern PGDLLIMPORT bbfSelectIntoAddIdentity_hook_type bbfSelectIntoAddIdentity_hook;
-
 #endif							/* UTILITY_H */