Adding parser support for AT TIME ZONE #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add an appropriate description to your PRs |
forestkeeper
previously approved these changes
Sep 15, 2023
surendravishnoi
previously approved these changes
Sep 19, 2023
…mp utils (babelfish-for-postgresql#218) * Add RPM spec file and Makefile logic Task: BABEL-4412 Signed-off-by: Rishabh Tanwar <[email protected]> * Fix spec file Signed-off-by: Rishabh Tanwar <[email protected]> * Add github action to test RPM Signed-off-by: Rishabh Tanwar <[email protected]> --------- Signed-off-by: Rishabh Tanwar <[email protected]> Co-authored-by: Rishabh Tanwar <[email protected]>
jsudrik
dismissed stale reviews from surendravishnoi and forestkeeper
The merge-base changed after approval.
jsudrik
force-pushed
the
BABEL_3_X_DEV__PG_15_X
branch
from
6e167ed to
3f3dc68
Compare
hash-16
requested review from
surendravishnoi and
forestkeeper
and removed request for
KushaalShroff
surendravishnoi
approved these changes
Sep 26, 2023
forestkeeper
approved these changes
Sep 26, 2023
forestkeeper
merged commit 1f0851f
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
2 checks passed
1 task
shardgupta
pushed a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
Sep 27, 2023
It converts an inputdate (datetime,smalldatetime,datetime2,datetimeoffset) to the corresponding datetimeoffset value in the target time zone. ``` Select convert(datetime,'2022-03-27T01:01:00') AT TIME ZONE 'Atlantic Standard Time' 2022-03-27 01:01:00.000 -03:00 Here it considers that the given time is currently in the target time zone so no change in the time is observed it just adds the offset. ``` Engine PR :- [Link](babelfish-for-postgresql/postgresql_modified_for_babelfish#215) Issues Resolved: BABEL-986 Signed-off-by: Ashish Prasad <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 16, 2023
* Adding parser support for AT TIME ZONE Signed-off-by: Rishabh Tanwar <[email protected]> Co-authored-by: Ashish Prasad <[email protected]> Co-authored-by: Sai Rohan Basa <[email protected]> Task: BABEL-4412
priyansx
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 22, 2023
* Adding parser support for AT TIME ZONE Signed-off-by: Rishabh Tanwar <[email protected]> Co-authored-by: Ashish Prasad <[email protected]> Co-authored-by: Sai Rohan Basa <[email protected]> Task: BABEL-4412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a sql_dialect to engine grammer in order to hit sys catalog instead of pg_catalog function.
Extension PR :- Link
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.