Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS ONLY] Add RPM spec file and Makefile logic to build Babelfish dump utils #218

Conversation

rishabhtanwar29
Copy link
Contributor

@rishabhtanwar29 rishabhtanwar29 commented Sep 19, 2023

Description

This commit adds a spec file which can be used to create RPM
containing Babelfish dump utilities (bbf_dump/bbf_dumpall).
The commit also introduces few new Makefile targets described below:

  • sources: Bundles the repository source into a tarball.
  • rpm-only: creates an RPM using given RPM spec file.
  • rpm: Combines both of the above steps.
    Additionally, added a github action to verify the RPM build and utilites
    generated afterwards.

Task: BABEL-4412
Signed-off-by: Rishabh Tanwar [email protected]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Task: BABEL-4412
Signed-off-by: Rishabh Tanwar <[email protected]>
@rishabhtanwar29 rishabhtanwar29 changed the title Add RPM spec file and Makefile logic Add RPM spec file and Makefile logic to build Babelfish dump utils Sep 19, 2023
Signed-off-by: Rishabh Tanwar <[email protected]>
kuntalghosh
kuntalghosh previously approved these changes Sep 20, 2023
Signed-off-by: Rishabh Tanwar <[email protected]>
@rishabhtanwar29 rishabhtanwar29 changed the title Add RPM spec file and Makefile logic to build Babelfish dump utils [OSS ONLY] Add RPM spec file and Makefile logic to build Babelfish dump utils Sep 21, 2023
@jsudrik
Copy link

jsudrik commented Sep 21, 2023

This commit adds a spec file which can be used to create RPM
containing Babelfish dump utilities (bbf_dump/bbf_dumpall).

@jsudrik jsudrik merged commit 6e167ed into babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X Sep 21, 2023
@rishabhtanwar29 rishabhtanwar29 deleted the jira-babel-4412 branch September 21, 2023 15:10
jsudrik pushed a commit that referenced this pull request Sep 22, 2023
…mp utils (#218)

This commit adds a spec file which can be used to create RPM
containing Babelfish dump utilities (bbf_dump/bbf_dumpall).
The commit also introduces few new Makefile targets described below:

* **sources:** Bundles the repository source into a tarball.
* **rpm-only:** creates an RPM using given RPM spec file.
* **rpm:** Combines both of the above steps.

Additionally, added a github action to verify the RPM build and utilites
generated afterwards.

Task: BABEL-4412
Signed-off-by: Rishabh Tanwar <[email protected]>
Sairakan pushed a commit to amazon-aurora/postgresql_modified_for_babelfish that referenced this pull request Nov 16, 2023
…mp utils (babelfish-for-postgresql#218)

This commit adds a spec file which can be used to create RPM
containing Babelfish dump utilities (bbf_dump/bbf_dumpall).
The commit also introduces few new Makefile targets described below:

* **sources:** Bundles the repository source into a tarball.
* **rpm-only:** creates an RPM using given RPM spec file.
* **rpm:** Combines both of the above steps.

Additionally, added a github action to verify the RPM build and utilites
generated afterwards.

Task: BABEL-4412
Signed-off-by: Rishabh Tanwar <[email protected]>
priyansx pushed a commit to amazon-aurora/postgresql_modified_for_babelfish that referenced this pull request Nov 22, 2023
…mp utils (babelfish-for-postgresql#218)

This commit adds a spec file which can be used to create RPM
containing Babelfish dump utilities (bbf_dump/bbf_dumpall).
The commit also introduces few new Makefile targets described below:

* **sources:** Bundles the repository source into a tarball.
* **rpm-only:** creates an RPM using given RPM spec file.
* **rpm:** Combines both of the above steps.

Additionally, added a github action to verify the RPM build and utilites
generated afterwards.

Task: BABEL-4412
Signed-off-by: Rishabh Tanwar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants