TVP as an argument of a procedure does not require TypeName to be specified #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey predicate (babelfish-for-postgresql#2917) Previously for a query we were observing a performance degradation when it included a join between sys.indexes, sys.index_columns, sys.columns, sys.tables, and sys.schemas views with sys.indexes.is_primary_key = 1 predicate in where clause. We identified that there was the issue with a case statement due to which there was an incorrect row estimation so we have implemented a direct cast by defining new IMPLICIT cast without function from boolean to sys.bit. Another issue was the use of redundant has_schema_privilege in sys views and functions, as we explicitly grant usage to public beforehand, so we have removed the redundant has_schema_privilege check. Issues Resolved: BABEL-5215 Signed-off-by: Tanya Gupta <[email protected]>
…cified (babelfish-for-postgresql#3107) The type name of the specified table-valued parameter as an argument for a procedure should be optional. Currently, babelfish does not support this since we need explicit type to create the temp table. We are fixing it by doing a look up of the typename of the TVP argument based on procedure name, namespace, db and role and setting the same. Issues Resolved BABEL-5311 Signed-off-by: Tanya Gupta <[email protected]>
Signed-off-by: Tanya Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type name of the specified table-valued parameter as an argument for a procedure should be optional. Currently, babelfish does not support this since we need explicit type to create the temp table.
We are fixing it by doing a look up of the typename of the TVP argument based on procedure name, namespace, db and role and setting the same.
Signed-off-by: Tanya Gupta [email protected]
Cherry-pick : #3107
Issues Resolved
BABEL-5311
Test Scenarios Covered
Use case based - Yes
Boundary conditions - NA
Arbitrary inputs - Yes
Negative test cases - NA
Minor version upgrade tests - Yes
Major version upgrade tests - Yes
Performance tests - NA
Tooling impact - NA
Client tests - Yes
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.