Performance improvements when query includes sys.indexes.is_primary_key predicate

[tanyagupta17]

Description

Previously for a query we were observing a performance degradation when it included a join between sys.indexes, sys.index_columns, sys.columns, sys.tables, and sys.schemas views with sys.indexes.is_primary_key = 1 predicate in where clause. We identified that there was the issue with a case statement due to which there was an incorrect row estimation so we have implemented a direct cast by defining new IMPLICIT cast without function from boolean to sys.bit.
Another issue was the use of redundant has_schema_privilege in sys views and functions, as we explicitly grant usage to public beforehand, so we have removed the redundant has_schema_privilege check.

Signed-off-by: Tanya Gupta [email protected]

Issues Resolved

BABEL-5215

Performance test:
Overall execution time(in sec) for 102 schemas, 2319 tables, 2535 key_constraints, 5885 indexes and 2034 types

Query	Before	After
Targeted Query	51	1.7
SSMS query to enumerate tables	1140	26

Test Scenarios Covered

• Use case based - Yes

• Boundary conditions - Yes

• Arbitrary inputs - Yes

• Negative test cases - Yes

• Minor version upgrade tests - Yes

• Major version upgrade tests - Yes

• Performance tests - Yes

• Tooling impact - N/A

• Client tests - N/A

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coveralls]

Pull Request Test Coverage Report for Build 11056938720

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 74.467%

---

Totals
Change from base Build 11056607399:	0.0%
Covered Lines:	44935
Relevant Lines:	60342

---

💛 - Coveralls

[sumitj824]

Please follow the guidelines for good PR title and description.

[sumitj824]

Please add a table in description for achieved performance improvements.

[sumitj824]

LGTM

[sumitj824]

LGTM with test changes.