Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sp_reset_connection test #3033

Conversation

sharathbp
Copy link
Contributor

@sharathbp sharathbp commented Oct 21, 2024

Description

"GO" statement was missing after sys.sp_reset_connection in Test-sp_reset_connection test due to which GUC was not resetting. Adding it to fix the test.

Task: BABEL-429

Signed-off-by: Sharath BP sharatbp@amazon.com
(cherry picked from commit 4e2c2a3)

Issues Resolved

BABEL-429

Test Scenarios Covered

  • Use case based -
    Yes

  • Boundary conditions -
    NA

  • Arbitrary inputs -
    NA

  • Negative test cases -
    NA

  • Minor version upgrade tests -
    NA

  • Major version upgrade tests -
    NA

  • Performance tests -
    NA

  • Tooling impact -
    NA

  • Client tests -
    NA

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sorry, something went wrong.

"GO" statement was missing after sys.sp_reset_connection in Test-sp_reset_connection test due to which GUC was not resetting. Adding it to fix the test.

Task: BABEL-429

Signed-off-by: Sharath BP <sharatbp@amazon.com>
(cherry picked from commit 4e2c2a3)
@sharathbp sharathbp changed the title Fix sp_reset_connection test (#3031) Fix sp_reset_connection test Oct 21, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11434991390

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.715%

Totals Coverage Status
Change from base Build 11401649532: 0.0%
Covered Lines: 43042
Relevant Lines: 58390

💛 - Coveralls

@shardgupta shardgupta merged commit 84e8c7f into babelfish-for-postgresql:BABEL_3_X_DEV Oct 21, 2024
43 checks passed
@shardgupta shardgupta deleted the babel-429-3x-test-fix branch October 21, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants