Fix sp_reset_connection test #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11403811137Details
💛 - Coveralls |
tanscorpio7
approved these changes
Oct 18, 2024
tanscorpio7
approved these changes
Oct 18, 2024
shardgupta
approved these changes
Oct 21, 2024
shardgupta
merged commit 4e2c2a3
into
babelfish-for-postgresql:BABEL_4_X_DEV
46 checks passed
sharathbp
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 21, 2024
"GO" statement was missing after sys.sp_reset_connection in Test-sp_reset_connection test due to which GUC was not resetting. Adding it to fix the test. Task: BABEL-429 Signed-off-by: Sharath BP <[email protected]> (cherry picked from commit 4e2c2a3)
sharathbp
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 21, 2024
"GO" statement was missing after sys.sp_reset_connection in Test-sp_reset_connection test due to which GUC was not resetting. Adding it to fix the test. Task: BABEL-429 Signed-off-by: Sharath BP <[email protected]> (cherry picked from commit 4e2c2a3)
shardgupta
pushed a commit
that referenced
this pull request
Oct 21, 2024
"GO" statement was missing after sys.sp_reset_connection in Test-sp_reset_connection test due to which GUC was not resetting. Adding it to fix the test. Task: BABEL-429 Signed-off-by: Sharath BP <[email protected]> (cherry picked from commit 4e2c2a3)
shardgupta
pushed a commit
that referenced
this pull request
Oct 21, 2024
"GO" statement was missing after sys.sp_reset_connection in Test-sp_reset_connection test due to which GUC was not resetting. Adding it to fix the test. Task: BABEL-429 Signed-off-by: Sharath BP <[email protected]> (cherry picked from commit 4e2c2a3)
manisha-deshpande
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 24, 2024
"GO" statement was missing after sys.sp_reset_connection in Test-sp_reset_connection test due to which GUC was not resetting. Adding it to fix the test. Task: BABEL-429 Signed-off-by: Sharath BP <[email protected]>
Deepesh125
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 28, 2024
"GO" statement was missing after sys.sp_reset_connection in Test-sp_reset_connection test due to which GUC was not resetting. Adding it to fix the test. Task: BABEL-429 Signed-off-by: Sharath BP <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves - Guidelines below (please delete the guidelines after writing the PR description)]
Issues Resolved
BABEL-429
Test Scenarios Covered
Use case based -
Yes
Boundary conditions -
NA
Arbitrary inputs -
NA
Negative test cases -
NA
Minor version upgrade tests -
NA
Major version upgrade tests -
NA
Performance tests -
NA
Tooling impact -
NA
Client tests -
NA
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.