This repository has been archived by the owner on May 19, 2018. It is now read-only.
get / set are valid property names in default assignment #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this was also reported in #112. |
danez
suggested changes
Sep 26, 2016
| @@ -774,7 +774,7 @@ pp.parseObjPropValue = function (prop, startPos, startLoc, isGenerator, isAsync, | |||
| return this.finishNode(prop, "ObjectProperty"); | |||
| } | |||
|
|
|||
| if (!prop.computed && prop.key.type === "Identifier" && (prop.key.name === "get" || prop.key.name === "set") && (!this.match(tt.comma) && !this.match(tt.braceR))) { | |||
| if (!isPattern && !prop.computed && prop.key.type === "Identifier" && (prop.key.name === "get" || prop.key.name === "set") && (!this.match(tt.comma) && !this.match(tt.braceR))) { | |||
| if (isGenerator || isAsync || isPattern) this.unexpected(); | |||
There was a problem hiding this comment.
|| isPattern can now be removed as it will never be true.
Current coverage is 94.47% (diff: 50.00%)@@ master #142 diff @@
==========================================
Files 19 19
Lines 3111 3111
Methods 327 327
Messages 0 0
Branches 818 818
==========================================
Hits 2939 2939
Misses 94 94
Partials 78 78
|
danez
approved these changes
Sep 27, 2016
|
Thank you |
|
Upps wrong button :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is valid syntax, but currently fails to compile with babel