get / set are valid property names in default assignment

babel · Sep 27, 2016 · 638f78d · 638f78d
1 parent 44d44a2
commit 638f78d
Show file tree

Hide file tree

Showing 3 changed files with 506 additions and 2 deletions.
diff --git a/src/parser/expression.js b/src/parser/expression.js
@@ -774,8 +774,8 @@ pp.parseObjPropValue = function (prop, startPos, startLoc, isGenerator, isAsync,
     return this.finishNode(prop, "ObjectProperty");
   }
 
-  if (!prop.computed && prop.key.type === "Identifier" && (prop.key.name === "get" || prop.key.name === "set") && (!this.match(tt.comma) && !this.match(tt.braceR))) {
-    if (isGenerator || isAsync || isPattern) this.unexpected();
+  if (!isPattern && !prop.computed && prop.key.type === "Identifier" && (prop.key.name === "get" || prop.key.name === "set") && (!this.match(tt.comma) && !this.match(tt.braceR))) {
+    if (isGenerator || isAsync) this.unexpected();
     prop.kind = prop.key.name;
     this.parsePropertyName(prop);
     this.parseMethod(prop, false);

diff --git a/test/fixtures/es2015/uncategorised/355/actual.js b/test/fixtures/es2015/uncategorised/355/actual.js
@@ -0,0 +1 @@
+function x({ set = null }) {}