Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix lint #20

Merged
merged 2 commits into from
Sep 4, 2024
Merged

chore: Fix lint #20

merged 2 commits into from
Sep 4, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Aug 31, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Aug 31, 2024
@dudong2 dudong2 added Type: CI and removed C:Types labels Aug 31, 2024
@github-actions github-actions bot added C:Types and removed Type: CI labels Aug 31, 2024
@dudong2 dudong2 mentioned this pull request Aug 31, 2024
11 tasks
@dudong2 dudong2 requested a review from jasonsong0 September 2, 2024 02:29
Copy link

@jasonsong0 jasonsong0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit c0430f3 into basechain/abci1.0/delevelop Sep 4, 2024
9 checks passed
@dudong2 dudong2 deleted the chore/fix-lint branch September 4, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants