-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: precompiled contract poc #19
feat: precompiled contract poc #19
Conversation
this pr will be changed to r4r after merging fix-lint pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except one comment I mentioned.
You can ignore it if there's no need to include customContract for prepareAccessList
745f400
to
f434835
Compare
feat: add precompiled contract logs using cosmos event converter
@@ -139,6 +141,10 @@ type ( | |||
address *common.Address | |||
slot *common.Hash | |||
} | |||
precompileChange struct { | |||
ms sdk.MultiStore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Question] Is there any reason why multiStore was changed to ms and events to es?
[Suggestion] How abount snapshot and events? You can ignore this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question but entilrely, LGTM.
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)