Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: precompiled contract poc #19

Merged
merged 16 commits into from
Sep 11, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Aug 23, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 changed the base branch from releases/v0.19.3-hotfix to basechain/abci1.0/delevelop August 31, 2024 05:21
@dudong2 dudong2 changed the base branch from basechain/abci1.0/delevelop to releases/v0.19.3-hotfix August 31, 2024 05:22
@dudong2 dudong2 marked this pull request as ready for review August 31, 2024 05:31
@dudong2 dudong2 changed the base branch from releases/v0.19.3-hotfix to basechain/abci1.0/delevelop August 31, 2024 06:11
@dudong2 dudong2 self-assigned this Aug 31, 2024
@dudong2 dudong2 marked this pull request as draft August 31, 2024 15:51
@dudong2
Copy link
Collaborator Author

dudong2 commented Aug 31, 2024

this pr will be changed to r4r after merging fix-lint pr

@dudong2 dudong2 requested a review from jasonsong0 September 2, 2024 02:28
Copy link

@jasonsong0 jasonsong0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except one comment I mentioned.
You can ignore it if there's no need to include customContract for prepareAccessList

x/evm/keeper/state_transition.go Outdated Show resolved Hide resolved
@dudong2 dudong2 force-pushed the feat/precompiled-bank-contract branch from 745f400 to f434835 Compare September 4, 2024 05:27
@dudong2 dudong2 marked this pull request as ready for review September 6, 2024 04:54
@dudong2 dudong2 added the enhancement New feature or request label Sep 9, 2024
@dongsam dongsam requested a review from cloudgray September 11, 2024 02:30
@dudong2 dudong2 changed the base branch from basechain/abci1.0/delevelop to basechain/abci1.0/develop September 11, 2024 03:00
@dudong2 dudong2 requested a review from jasonsong0 September 11, 2024 03:03
feat: add precompiled contract logs using cosmos event converter
@@ -139,6 +141,10 @@ type (
address *common.Address
slot *common.Hash
}
precompileChange struct {
ms sdk.MultiStore
Copy link
Collaborator

@cloudgray cloudgray Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] Is there any reason why multiStore was changed to ms and events to es?
[Suggestion] How abount snapshot and events? You can ignore this.

Copy link
Collaborator

@cloudgray cloudgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question but entilrely, LGTM.

@dudong2 dudong2 merged commit 397c773 into basechain/abci1.0/develop Sep 11, 2024
8 of 9 checks passed
@dudong2 dudong2 deleted the feat/precompiled-bank-contract branch September 11, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants