-
Notifications
You must be signed in to change notification settings - Fork 0
Fix: wrong denom check at RegsterCoin and remove IBC-related tests #6
Fix: wrong denom check at RegsterCoin and remove IBC-related tests #6
Conversation
Check registered denom using `coinMetadata.Base` not `.Name` details: b-harvest@d01eab0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to Cherry-pick below PRs without canto v8(sdk 50) dependent code
- feat(erc20): add indexes at genesis state to track active token pairs Canto#68
- Fix: wrong denom check at RegisterCoin Canto#78
Could you backport patch for b-harvest#68 or If you think a is not necessary, please leave a comment about the reason @jasonsong0
The index was added as a patch for the existence of multiple token pairs with the same denom, which should not happen if the above PR is fixed. |
@jasonsong0 It might be a good to backporting patch proceed with b-harvest#68 even after applying the duplication prevention patch b-harvest#78 for the following reasons:
@zsystm , If you have any opinions on this as well, Please let us know |
Agree with @dongsam Ah ha. You already added commits. I'll review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- same denom and multiple token pair bug should not happen in this codebase.
- the previous comments could be interpreted as if this issue can already occur or has occurred, so I have revised the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI. @jasonsong0 test-coverage CI failed.
LGTM, Please merge it If all the work is done @jasonsong0 |
Description
This is based on the following PRs patched in canto v8.
Problem
If multiple token pairs exist for same denom, the iteration order is based on bytes, not the registration order.
coinMetadata.Base
is used as the denom for the token pairbut
coinMetadata.Name
was used for checking registered token pairSolution
coinMatadata.Base
Proof of Work
Testcode Refactoring
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...