feat(erc20): add indexes at genesis state to track active token pairs #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudong2
reviewed
Jul 16, 2024
x/erc20/genesis_test.go
Outdated
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
|
|
||
| // TODO: fix duplicate problem and uncomment this line | ||
| //suite.Nil(tc.genesisState.Validate(), "genesis state should be valid") |
zsystm
force-pushed
the
patch/non-deterministic-denommap
branch
from
5b34645 to
acae2d0
Compare
zsystm
force-pushed
the
patch/non-deterministic-denommap
branch
from
0927856 to
bb1990b
Compare
- multiple token pairs can exists at the same denom - but only one active token pair can exist by index - so index must be handled as genesis state. without it, we cannot track what is the active token pair from multiple token pairs for same denom
problem - one token pair has two indexes - erc20 index - denom index - so, set token pair per indexes and delete keys is wrong - when iterate erc20 indexes, id is already gone. so it will set empty token pair multiple times solution - set token pair once when iterate token pairs
- currently we already have multiple token pairs for same denom which is not allowed for validation genesis - we have not decided yet for handling this.
Regardless of whether it’s OWNER_EXTERNAL or OWNER_MODULE, both indexes are being managed.
|
lgtm! |
dongsam
approved these changes
Jul 18, 2024
Co-authored-by: dongsam <[email protected]>
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Naming Change
The following maps exist for the purpose of indexing to find
TokenPair. I believe the new names better reflect their purpose:DenomMap-->TokenPairDenomIndexERC20Map-->TokenPairERC20AddressIndexAligned the following method names with their original intent and actual actions:
GetDenomMap-->GetTokenPairIdByDenomGetERC20Map-->GetTokenPairIdByERC20AddrAdded indexes as state
Problem
denomMap) and erc20AddressIndex(=erc20Map).ibc/13B6057538B93225F6EBACCB64574C49B2C1568C5AE6CCFE0A039D7DAC02BF29ends up with the TokenPair associated with0x2C68D1d6aB986Ff4640b51e1F14C716a076E44C4, which is incorrect.0xD32eB974468ed767338533842D2D4Cc90B9BAb46, as it was registered later and is currently active.Solution
Notes
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...