This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Feature/fix lab #121
Merged
Feature/fix lab #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartz
approved these changes
Dec 30, 2016
| }); | ||
| } | ||
|
|
||
| private isValidIndicator(indicator: Indicator): boolean { | ||
| return indicator.time_aggregation !== 'daily'; |
There was a problem hiding this comment.
We haven't quite gotten rid of the daily-only indicators yet, but they're going away in azavea/climate-change-api#199 so we should be fine pretending they're not there for the time being.
| @@ -51,7 +51,10 @@ export class ChartComponent implements OnChanges { | |||
| indicator: this.chart.indicator, | |||
| scenario: this.scenario, | |||
| city: this.city, | |||
| climateModels: this.models | |||
| climateModels: this.models, | |||
| // As a temporary solution, the time agg defaults to the 1st valid option. | |||
There was a problem hiding this comment.
Do we have a github issue to add selecting non-yearly granularities? That'd be pretty handy to have
There was a problem hiding this comment.
I don't think it has be discussed, but now that we do time aggs that seems like a necessary feature to lab.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newest changes to CC API, particularly time_aggregations, broke the CC lab graphs. This should restore any lost functionality. You'll see some comments with temporary simplifications.