This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The raw daily indicators have been a bit of a special case for indicators, since they don't need the time aggregation that our indicator framework is built around and aren't used by the lab. That they explicitly do not work with aggregations - a core principle of our indicators - was a cause of concern in #158, and the indicators themselves were made redundant in #162 by virtue that the aggregated variable indicators could be configured to be used for daily "aggregation".
This removes the indicators and increases the flexibility of the basic indicators AverageHighTemperature, AverageLowTemperature, MaxHighTemperature, MaxLowTemperature, and TotalPrecipitation to all permit daily aggregation.
Testing Instructions
Closes #172