Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Remove raw daily indicators #199

Merged
merged 1 commit into from
Dec 30, 2016
Merged

Remove raw daily indicators #199

merged 1 commit into from
Dec 30, 2016

Conversation

rmartz
Copy link
Contributor

@rmartz rmartz commented Dec 29, 2016

Overview

The raw daily indicators have been a bit of a special case for indicators, since they don't need the time aggregation that our indicator framework is built around and aren't used by the lab. That they explicitly do not work with aggregations - a core principle of our indicators - was a cause of concern in #158, and the indicators themselves were made redundant in #162 by virtue that the aggregated variable indicators could be configured to be used for daily "aggregation".

This removes the indicators and increases the flexibility of the basic indicators AverageHighTemperature, AverageLowTemperature, MaxHighTemperature, MaxLowTemperature, and TotalPrecipitation to all permit daily aggregation.

Testing Instructions

  • All tests should still pass
  • Basic indicators should support daily aggregation and give daily values when requested
    • (Note that daily values have a single data point per day, so average, max and min are indistinguishable)

Closes #172

@rmartz rmartz merged commit eaec024 into develop Dec 30, 2016
@rmartz rmartz deleted the feature/no_daily_indicators branch December 30, 2016 21:57
ddohler pushed a commit that referenced this pull request Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Daily Raw Data Indicators
2 participants