Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3445 Make config dependencies, module dependencies in az_paragraphs:az_paragraphs_view #3446

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented May 23, 2024

Description

Adding config dependencies for az_paragraphs_view
https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_paragraphs/az_paragraphs_views_side_by_side/config/install/views.view.az_side_by_side_views.yml#L6-L9

Adding update function to install dependencies if the az_paragraphs_views_side_by_side module is already installed.
Adding the dependencies to the info file.

Related issues

Closes #3445

How to test

On a quickstart site disable az_news and delete all of its config, or create a site without news in the first place.
Then try to enable the Quickstart Paragraphs - Views Side-by-Side module
See that you will need to install dependencies if you want to install Views Side-by-Side.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@trackleft trackleft marked this pull request as ready for review May 23, 2024 19:51
@trackleft trackleft requested a review from a team as a code owner May 23, 2024 19:51
@trackleft trackleft added the bug Something isn't working label May 23, 2024
@bberndt-uaz
Copy link
Contributor

I created a local Quickstart site without installing the Quickstart News module. When I tried to install the Quickstart Paragraphs - Views Side-by-Side module, the prompt to confirm the installation of Quickstart News was displayed:

image

However, since Quickstart SEO was installed, Quickstart News could not be installed.

image

Once I reinstalled Quickstart without both Quickstart News and Quickstart SEO, I was able to install Quickstart Paragraphs - Views Side-by-Side successfully.

image

I'm not sure what the best solution would be in this case.

RyanDool
RyanDool previously approved these changes Jun 21, 2024
@trackleft
Copy link
Member Author

trackleft commented Jun 21, 2024

Looks like we need another ticket for adding dependencies to https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_seo/az_seo.info.yml

Created #3498

joeparsons
joeparsons previously approved these changes Jun 21, 2024
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Jun 21, 2024
bberndt-uaz
bberndt-uaz previously approved these changes Jun 21, 2024
@joeparsons
Copy link
Member

Going to move this to the 2.10.6 project so we can do more testing / ensure that DB updates aren't needed.

tadean
tadean previously approved these changes Jul 10, 2024
@danahertzberg
Copy link
Contributor

Check for DB updates needed/not needed. @joeparsons to answer before merging.

@trackleft trackleft dismissed stale reviews from bberndt-uaz, tadean, RyanDool, and joeparsons via 882d998 July 11, 2024 22:58
@joeparsons joeparsons merged commit 6663cf5 into main Jul 26, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3445-side-by-side-depends branch July 26, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch release Issues to be included in the next patch release
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Add dependencies to Quickstart Paragraphs - Views Side-by-Side.
6 participants