-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1822 - Move page title block to content_top region #1834
Conversation
This will update existing sites. Please wait to merge until we run it by leadership. |
Patch existing sites like this:
|
Have we tested that this works for existing sites? |
In case it isn't totally obvious to everyone, the title block bottom margin combined with the sidebar top margin do bring the sidebar out of alignment with the body content on that particular site. |
I think that'll be a non-issue once I update #1835 and we get it merged; that PR will remove the sidebar margin-top. |
Cool, just didn't want it to get overlooked. |
Blocked or should be merged together into main with #1835 |
Could consider adding a new region for page title that uses the display flex classes. Float right when sidebar is next to it, but fill the whole column when using full width elements at the top of a page (below the title). |
Thank you Ashley for your time today. I do see value in moving the page title block to the content_top region until we have a solution for mobile navigation that address the multiple levels of navigation question. |
Decided in 2023-08-04 Friday meeting to close this for now. We can definitely re-open/re-create this if needed later. |
Description
Moves the page title block to the
content_top
region to improve page title clarity and prevent the title from displaying below thesidebar_first
region on mobile.Review site: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-1834.probo.build/
Related issues
Closes #1822
Related to: #1835
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist