Closes #1122 Add callout variants for all theme colors. #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmunro-ltrr
previously approved these changes
Jan 25, 2024
There was a problem hiding this comment.
The documentation on the main branch needs an overhaul to align it with upstream Bootstrap v5, but that's a different issue. One relevant section there is
https://getbootstrap.com/docs/5.3/customize/components/#creating-your-own
Regenerating the package-lock.json yet again was necessary to get a local lint check to pass.
danahertzberg
previously approved these changes
Jan 26, 2024
trackleft
previously approved these changes
Jan 26, 2024
joeparsons
commented
Jan 30, 2024
joeparsons
dismissed stale reviews from trackleft, danahertzberg, and mmunro-ltrr
via
ffcd3ad
mmunro-ltrr
approved these changes
Jan 30, 2024
danahertzberg
approved these changes
Jan 31, 2024
bberndt-uaz
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1122
Review site: https://review.digital.arizona.edu/arizona-bootstrap/issue/1122/docs/5.0/components/callouts/
How to test
Verify Standard CKEditor can accept and appropriately display the following classes on a div.