⬆ Bump cosmwasm 2.0.x #605
Conversation
WalkthroughThe changes encompass significant updates to the dependencies and functionality across multiple projects within the CosmWasm ecosystem. Key adjustments include upgrading libraries, streamlining type declarations by removing unnecessary lifetime annotations, and enhancing test clarity through more consistent use of message info. The introduction of a local testing package facilitates better address handling and mock environment setup, contributing to improved testing practices and overall code maintainability. Changes
Sequence Diagram(s)sequenceDiagram
participant A as Contract
participant B as Testing Framework
participant C as Address Module
A->>B: Send transaction request
B->>C: Retrieve address info
C->>B: Return address
B->>A: Execute transaction with address
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
bdeneux
force-pushed
the
chore/bump-cosmwasm-2.0.x
branch
from
7d431e2
to
31e0566
Compare
bdeneux
force-pushed
the
chore/bump-cosmwasm-2.0.x
branch
from
a0a2308
to
061419b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
Files selected for processing (27)
- Cargo.toml (2 hunks)
- Makefile.toml (1 hunks)
- contracts/axone-cognitarium/Cargo.toml (1 hunks)
- contracts/axone-cognitarium/src/contract.rs (23 hunks)
- contracts/axone-cognitarium/src/state/blank_nodes.rs (1 hunks)
- contracts/axone-cognitarium/src/state/namespaces.rs (2 hunks)
- contracts/axone-cognitarium/src/state/store.rs (1 hunks)
- contracts/axone-cognitarium/src/state/triples.rs (1 hunks)
- contracts/axone-cognitarium/tests/e2e/main.rs (3 hunks)
- contracts/axone-dataverse/Cargo.toml (1 hunks)
- contracts/axone-dataverse/src/contract.rs (13 hunks)
- contracts/axone-dataverse/src/registrar/rdf.rs (2 hunks)
- contracts/axone-dataverse/src/state.rs (1 hunks)
- contracts/axone-law-stone/Cargo.toml (1 hunks)
- contracts/axone-law-stone/src/contract.rs (13 hunks)
- contracts/axone-law-stone/src/state.rs (2 hunks)
- contracts/axone-objectarium/Cargo.toml (1 hunks)
- contracts/axone-objectarium/src/contract.rs (62 hunks)
- contracts/axone-objectarium/src/crypto.rs (2 hunks)
- contracts/axone-objectarium/src/state.rs (4 hunks)
- docs/axone-cognitarium.md (1 hunks)
- docs/axone-law-stone.md (1 hunks)
- packages/testing/Cargo.toml (1 hunks)
- packages/testing/Makefile.toml (1 hunks)
- packages/testing/src/addr.rs (1 hunks)
- packages/testing/src/lib.rs (1 hunks)
- packages/testing/src/mock.rs (1 hunks)
Files skipped from review due to trivial changes (10)
- contracts/axone-cognitarium/src/state/blank_nodes.rs
- contracts/axone-cognitarium/src/state/store.rs
- contracts/axone-dataverse/src/state.rs
- contracts/axone-law-stone/src/state.rs
- contracts/axone-objectarium/src/state.rs
- docs/axone-cognitarium.md
- docs/axone-law-stone.md
- packages/testing/Cargo.toml
- packages/testing/src/addr.rs
- packages/testing/src/lib.rs
Additional comments not posted (77)
packages/testing/Makefile.toml (1)
1-1: File approved.The new task schema is correctly added.
packages/testing/src/mock.rs (1)
1-9: File approved.The function
mock_env_addrcorrectly sets up a mock environment with the contract address.contracts/axone-law-stone/Cargo.toml (1)
37-37: File approved.The addition of the
testingworkspace dependency is appropriate, and the removal of thebacktracesfeature is noted.contracts/axone-objectarium/Cargo.toml (2)
42-42: Verify the rationale behind commenting out thebacktracesfeature.Commenting out the
backtracesfeature suggests a change in error handling or debugging strategy. Ensure this aligns with the project's error handling policies and consider documenting the rationale for future reference.
42-42: LGTM!The addition of
testing.workspace = trueenhances the testing capabilities of the project by ensuring a properly set up testing environment within the workspace context.contracts/axone-dataverse/Cargo.toml (2)
44-44: Verify the rationale behind removing thebacktracesfeature.The removal of the
backtracesfeature suggests a change in error handling or debugging strategy. Ensure this aligns with the project's error handling policies and consider documenting the rationale for future reference.
44-44: LGTM!The addition of
testing.workspace = trueenhances the testing capabilities of the project by ensuring a properly set up testing environment within the workspace context.contracts/axone-cognitarium/Cargo.toml (1)
44-44: LGTM!The addition of
testing.workspace = trueenhances the testing capabilities of the project by ensuring a properly set up testing environment within the workspace context.Cargo.toml (7)
28-28: Upgradecosmwasm-schemato version 2.1.1.The dependency
cosmwasm-schemahas been upgraded from1.5.5to2.1.1. Ensure that the new version is compatible with the rest of the codebase and that any breaking changes are addressed.
29-29: Upgradecosmwasm-stdto version 2.1.1 with featurecosmwasm_2_1.The dependency
cosmwasm-stdhas been upgraded from1.5.5to2.1.1with a feature change fromcosmwasm_1_2tocosmwasm_2_1. Ensure that the new version and feature are compatible with the rest of the codebase and that any breaking changes are addressed.
31-31: Upgradecw-multi-testto version 2.1.0.The dependency
cw-multi-testhas been upgraded from0.20.1to2.1.0. Ensure that the new version is compatible with the rest of the codebase and that any breaking changes are addressed.
32-32: Upgradecw-storage-plusto version 2.0.0.The dependency
cw-storage-plushas been upgraded from1.2.0to2.0.0. Ensure that the new version is compatible with the rest of the codebase and that any breaking changes are addressed.
33-33: Upgradecw-utilsto version 2.0.0.The dependency
cw-utilshas been upgraded from1.0.3to2.0.0. Ensure that the new version is compatible with the rest of the codebase and that any breaking changes are addressed.
34-34: Upgradecw2to version 2.0.0.The dependency
cw2has been upgraded from1.1.1to2.0.0. Ensure that the new version is compatible with the rest of the codebase and that any breaking changes are addressed.
44-44: Add local dependencytesting.A new dependency
testinghas been added, pointing to a local package. Ensure that the local package exists and is correctly referenced.contracts/axone-objectarium/src/crypto.rs (2)
126-126: AddKEY_ELEMSconstant toKeyDeserializeforHash.The
KEY_ELEMSconstant has been added to theKeyDeserializetrait implementation forHash, improving clarity and type safety.
136-136: AddKEY_ELEMSconstant toKeyDeserializefor&Hash.The
KEY_ELEMSconstant has been added to theKeyDeserializetrait implementation for&Hash, improving clarity and type safety.contracts/axone-cognitarium/tests/e2e/main.rs (2)
6-6: Addmessage_infoimport.The
message_infoimport has been added to support the updated initialization method.
30-30: Updateinfoinitialization to usemessage_info.The initialization of the
infofield inSmartContractWorldhas been updated to usemessage_infowith an address derived from theaddrfunction, improving the realism of the test setup.contracts/axone-cognitarium/src/state/triples.rs (1)
Line range hint
23-27:
Simplified return type improves flexibility.The removal of the lifetime parameter
'afrom the return type of thetriplesfunction simplifies the function signature and potentially allows for more flexible use of theIndexedMap.contracts/axone-cognitarium/src/state/namespaces.rs (2)
10-10: Simplified type signature improves clarity.The removal of the lifetime parameter
'_'from the type signature of theNAMESPACE_KEY_INCREMENTconstant makes the definition cleaner and potentially easier to use.
Line range hint
35-39:
Simplified return type improves flexibility.The removal of the lifetime parameter
'afrom the return type of thenamespacesfunction simplifies the function signature and potentially allows for more flexible use of theIndexedMap.contracts/axone-dataverse/src/registrar/rdf.rs (2)
271-273: Improved handling of byte data.The change from
serialization_res.unwrap().0toserialization_res.unwrap().to_vec()ensures that the byte data is correctly transformed into a vector before being converted to a UTF-8 string, preventing potential issues related to ownership or borrowing.
304-306: Improved handling of byte data.The change from
serialization_res.unwrap().0toserialization_res.unwrap().to_vec()ensures that the byte data is correctly transformed into a vector before being converted to a UTF-8 string, preventing potential issues related to ownership or borrowing.Makefile.toml (1)
627-627: Update dependency version.The version of
cosmwasm-checkhas been updated from1.5.3to2.1.1. Ensure that the new version is compatible with the rest of the codebase and that any breaking changes are addressed.contracts/axone-dataverse/src/contract.rs (12)
34-34: Improve type safety.Passing
checksumas a slice usingchecksum.as_slice()improves type safety and compatibility with the expected parameter type.
150-150: Enhance clarity in test cases.Replacing
mock_infowithmessage_infoimproves the clarity and consistency of address handling in the test cases.
152-152: Improve type instantiation.Using
Binary::new()for instantiation is more explicit and improves code readability.
191-192: Promote better practices.Using
message_infoand constants for addresses reduces the risk of errors due to string mismatches and promotes better code management practices.
226-226: Promote better practices.Using
message_infoand constants for addresses reduces the risk of errors due to string mismatches and promotes better code management practices.
275-275: Promote better practices.Using
message_infoand constants for addresses reduces the risk of errors due to string mismatches and promotes better code management practices.
343-346: Promote better practices.Using
message_infoand constants for addresses reduces the risk of errors due to string mismatches and promotes better code management practices.
408-411: Promote better practices.Using
message_infoand constants for addresses reduces the risk of errors due to string mismatches and promotes better code management practices.
427-430: Promote better practices.Using
message_infoand constants for addresses reduces the risk of errors due to string mismatches and promotes better code management practices.
449-452: Promote better practices.Using
message_infoand constants for addresses reduces the risk of errors due to string mismatches and promotes better code management practices.
471-474: Promote better practices.Using
message_infoand constants for addresses reduces the risk of errors due to string mismatches and promotes better code management practices.
522-525: Promote better practices.Using
message_infoand constants for addresses reduces the risk of errors due to string mismatches and promotes better code management practices.contracts/axone-law-stone/src/contract.rs (9)
288-288: Enhance clarity in test cases.Replacing
mock_infowithmessage_infoimproves the clarity and consistency of address handling in the test cases.
300-300: Streamline object construction.Using a constructor method to initialize
ContractInfoResponsedirectly with parameters simplifies the code and enhances maintainability.
698-699: Expand functionality ofReplystruct.Adding new fields
payloadandgas_usedto theReplystruct allows for more comprehensive handling of contract interactions.
357-357: Promote better practices.Using constants for
CREATORandSENDERreduces the risk of errors due to string mismatches and promotes better code management practices.
397-397: Promote better practices.Using constants for
CREATORandSENDERreduces the risk of errors due to string mismatches and promotes better code management practices.
892-892: Promote better practices.Using constants for
CREATORandSENDERreduces the risk of errors due to string mismatches and promotes better code management practices.
937-946: Promote better practices.Using constants for
CREATORandSENDERreduces the risk of errors due to string mismatches and promotes better code management practices.
1060-1063: Promote better practices.Using constants for
CREATORandSENDERreduces the risk of errors due to string mismatches and promotes better code management practices.
1122-1131: Promote better practices.Using constants for
CREATORandSENDERreduces the risk of errors due to string mismatches and promotes better code management practices.contracts/axone-cognitarium/src/contract.rs (3)
511-511: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
message_infomatch the new usage.
455-455: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
message_infomatch the new usage.Verification successful
Verified: The usage of
message_infomatches the new pattern throughout the codebase.The instances of
message_infoin the codebase are consistent with the new usage pattern as shown in the provided snippet.
contracts/axone-cognitarium/src/contract.rscontracts/axone-dataverse/src/contract.rscontracts/axone-objectarium/src/contract.rscontracts/axone-law-stone/src/contract.rscontracts/axone-cognitarium/tests/e2e/main.rsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `message_info` match the new usage. # Test: Search for the function usage. Expect: Only occurrences of the new usage. rg --type rust -A 5 $'message_info'Length of output: 51210
576-576: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
message_infomatch the new usage.contracts/axone-objectarium/src/contract.rs (28)
1938-1941: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.
[
122-122: LGTM! But verify the function usage in the codebase.The transition from
data.0todata.to_vec()enhances flexibility and correctness of data handling.However, ensure that all function calls to
store_objectmatch the new data handling approach.
446-446: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases use the new
message_infoapproach.The change from
mock_infotomessage_infohas been consistently applied across the test cases.
- Verified in
contracts/axone-dataverse/src/contract.rs- Verified in
contracts/axone-objectarium/src/contract.rs- Verified in
contracts/axone-cognitarium/src/contract.rs- Verified in
contracts/axone-law-stone/src/contract.rsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
814-814: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.
1378-1378: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification successful: All test cases use the new
message_infoapproach.The transition from
mock_infotomessage_infohas been consistently applied across the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
1258-1258: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification successful: All test cases use the new
message_infoapproach.The transition from
mock_infotomessage_infohas been thoroughly implemented across the codebase.
contracts/axone-law-stone/src/contract.rscontracts/axone-objectarium/src/contract.rscontracts/axone-cognitarium/src/contract.rscontracts/axone-dataverse/src/contract.rsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
130-130: LGTM! But verify the function usage in the codebase.The transition from
data.0todatafor compression enhances flexibility and correctness of data handling.However, ensure that all function calls to
store_objectmatch the new data handling approach.Verification successful
Verification successful.
All instances of the
store_objectfunction match the new data handling approach usingdatadirectly.
contracts/axone-objectarium/src/contract.rs: All calls and definitions ofstore_objectuse thedataparameter correctly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `store_object` match the new data handling approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'store_object'Length of output: 15480
Script:
#!/bin/bash # Description: Verify all function calls to `store_object` match the new data handling approach. # Test: Search for the function usage with more context lines. Expect: Only occurrences of the new approach. rg --type rust -A 10 -B 10 $'store_object'Length of output: 36904
453-453: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification Successful: All test cases use the new
message_infoapproach.The transition from
mock_infotomessage_infohas been fully implemented across the codebase, ensuring consistency and clarity in the test cases.
- No instances of
mock_infowere found in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that there are no remaining instances of the old `mock_info` approach. # Test: Search for the old `mock_info` function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
599-605: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases have been updated to use the new
message_infoapproach.
- No instances of the old
mock_infofunction were found in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that no test cases use the old `mock_info` approach. # Test: Search for any remaining usage of the old `mock_info` function. Expect: No occurrences. rg --type rust -A 5 $'mock_info'Length of output: 31
753-758: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases have been updated to use
message_info.The search did not return any instances of
mock_info, confirming that the update has been consistently applied across the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify no test cases use the old `mock_info` approach. # Test: Search for the function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
828-828: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification Successful
All test cases have been updated to use the new
message_infoapproach. No instances of the oldmock_infowere found in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that no test cases use the old `mock_info` approach. # Test: Search for the function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
527-527: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases use the new
message_infoapproach.The verification confirms that
mock_infohas been completely replaced bymessage_infoacross the codebase.
- No instances of
mock_infowere found.- Multiple instances of
message_infowere found, confirming its consistent usage.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that `mock_info` has been completely replaced by `message_info`. # Test: Search for any remaining occurrences of `mock_info`. Expect: No occurrences. rg --type rust -A 5 $'mock_info'Length of output: 31
778-778: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases have been successfully updated to use the new
message_infoapproach.
- No occurrences of the old
mock_infofunction were found in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that the old `mock_info` function is no longer used in the codebase. # Test: Search for any occurrences of `mock_info`. Expect: No occurrences. rg --type rust -A 5 $'mock_info'Length of output: 31
795-795: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification Successful: All test cases use the new
message_infoapproach.
- The transition from
mock_infotomessage_infohas been completed successfully across the codebase.- No instances of
mock_infowere found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that there are no remaining instances of `mock_info` in the codebase. # Test: Search for the function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
484-484: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification successful: All test cases use the new
message_infoapproach.The search for
mock_inforeturned no results, indicating that all instances have been replaced withmessage_info.
- No occurrences of
mock_infofound in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify all test cases have replaced `mock_info` with `message_info`. # Test: Search for any remaining instances of `mock_info`. Expect: No occurrences. rg --type rust $'mock_info'Length of output: 26
1042-1042: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification complete: All test cases use the new
message_infoapproach.The search for
mock_inforeturned no results, confirming that the transition tomessage_infohas been fully implemented across the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that there are no remaining instances of the old `mock_info` function. # Test: Search for the old function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
1543-1543: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases use the new
message_infoapproach.The transition from
mock_infotomessage_infohas been fully implemented across the codebase, ensuring clarity and consistency in the test cases.
- No occurrences of
mock_infowere found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that the old `mock_info` function is no longer used in the codebase. # Test: Search for any occurrences of `mock_info`. Expect: No occurrences. rg --type rust -A 5 $'mock_info'Length of output: 31
1768-1768: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases use the new
message_infoapproach.The transition from
mock_infotomessage_infohas been successfully completed across the codebase.
- No instances of
mock_infowere found.message_infois used consistently in test cases.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that there are no remaining instances of the old `mock_info` function. # Test: Search for the function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
1629-1629: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases use the new
message_infoapproach.The search for
mock_inforeturned no results, confirming that all test cases have been updated to use the newmessage_infoapproach.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that there are no remaining instances of the old `mock_info` function in the codebase. # Test: Search for the old function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
1865-1868: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification successful: All test cases use the new
message_infoapproach.The search confirmed that there are no remaining instances of the old
mock_infofunction in the codebase. All test cases have been updated to usemessage_info, ensuring clarity and consistency.
- No occurrences of
mock_infofound.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that no test cases use the old `mock_info` approach. # Test: Search for the function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
1588-1588: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases now use the
message_infoapproach.The transition from
mock_infotomessage_infohas been successfully completed across the codebase.
- No instances of
mock_infowere found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that there are no remaining instances of `mock_info` in the codebase. # Test: Search for the old function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
1834-1837: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases use the new
message_infoapproach.The verification confirms that no instances of the old
mock_infoapproach remain in the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that no test cases use the old `mock_info` approach. # Test: Search for the function usage. Expect: No occurrences of the old approach. rg --type rust -A 5 $'mock_info'Length of output: 31
1811-1814: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification successful: All test cases use the new
message_infoapproach.
- The search for
mock_inforeturned no results, confirming the complete transition tomessage_info.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that `mock_info` is no longer in use. # Test: Search for any remaining instances of `mock_info`. Expect: No occurrences of the old approach. rg --type rust $'mock_info'Length of output: 26
1900-1902: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification successful: All test cases use the new
message_infoapproach.
- The search results confirmed that
mock_infohas been fully replaced bymessage_info.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that `mock_info` has been fully replaced by `message_info` in the codebase. # Search for any occurrences of `mock_info` in the codebase. rg --type rust 'mock_info'Length of output: 26
1675-1675: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification Successful: All test cases use the new
message_infoapproach.The codebase has fully transitioned from
mock_infotomessage_info, ensuring consistency and clarity in the test cases.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that the old `mock_info` function is no longer used in the codebase. # Test: Search for any occurrences of the old `mock_info` function. rg --type rust $'mock_info'Length of output: 26
1128-1128: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases use the new
message_infoapproach.The verification confirms that there are no remaining instances of
mock_infoin the codebase, indicating a successful transition tomessage_info.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that no test cases use the old `mock_info` approach. # Test: Search for any occurrences of the old `mock_info` function. rg --type rust -A 5 $'mock_info'Length of output: 31
559-559: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
Verification complete: All test cases use the new
message_infoapproach.The search did not return any instances of
mock_info, confirming that the transition tomessage_infois complete across the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that no test cases use the old `mock_info` approach. # Test: Search for any occurrences of the old `mock_info` function. rg --type rust -A 5 $'mock_info'Length of output: 31
1788-1791: LGTM! But verify the function usage in the codebase.The change from
mock_infotomessage_infoimproves clarity and consistency in the test cases.However, ensure that all test cases use the new
message_infoapproach.Verification successful
All test cases use the new
message_infoapproach, and no instances ofmock_infowere found in the codebase.
- The transition from
mock_infotomessage_infois complete.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all test cases use the new `message_info` approach. # Test: Search for the function usage. Expect: Only occurrences of the new approach. rg --type rust -A 5 $'message_info'Length of output: 51210
Script:
#!/bin/bash # Description: Verify that the old `mock_info` function is not used anywhere in the codebase. # Test: Search for any occurrences of `mock_info`. Expect: No occurrences. rg --type rust -A 5 $'mock_info'Length of output: 31
There was a problem hiding this comment.
Nice thanks 🙏
I noticed the addition of the payload field when using sub messages to avoid storing temporary context: CosmWasm/cosmwasm#2008
Maybe we could take the opportunity to use it in the law stone instantiation, we can do that in another PR if you prefer
|
@amimart Yes, I will do the changes but like you say, I prefer to do it in another PR. I merge this one. |
This PR updates CosmWasm to v2.1.1 following the migration guide.
Additionally, a
testingpackage has been added to provide common testing utility functions. Since CosmWasm 2.0.0 introduced a new API for mocking info and requires a valid address, this helper library has been created to avoid duplicating utility functions. It includes functions to generate valid addresses in the mocked environment, addressing the issue described in CosmWasm issue #2157.