Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add payload field to SubMsg and Reply #2008

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Add payload field to SubMsg and Reply #2008

merged 7 commits into from
Jan 30, 2024

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Jan 29, 2024 •
edited
Loading

Closes #1909

  • Implementation
  • CHANGELOG entry
  • MIGRATING entry

@webmaster128 webmaster128 mentioned this pull request Jan 29, 2024
Closed
chipshort
chipshort reviewed Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only typos and changelog entry.

packages/std/src/results/submessages.rs Outdated Show resolved Hide resolved
packages/std/src/results/submessages.rs Outdated Show resolved Hide resolved
@webmaster128
Copy link
Member Author

@hashedone @jawoznia @DariuszDepta this is the Reply payload I mentioned today. The pair (id, payload) is just copied 1:1 from the SubMsg emitted by the contract into the reply entry point. This allows the contract to add data needed for processing the reply.

@webmaster128 webmaster128 changed the title Add payload field to SubMsg Add payload field to SubMsg and Reply Jan 29, 2024
@webmaster128 webmaster128 force-pushed the add-Reply-payload branch 2 times, most recently from 211e6bd to bdc2807 Compare January 29, 2024 22:31
chipshort
chipshort approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but found another typo

packages/std/src/results/submessages.rs Outdated Show resolved Hide resolved
packages/std/src/results/submessages.rs Show resolved Hide resolved
@webmaster128 webmaster128 merged commit 30f4854 into main Jan 30, 2024
29 checks passed
@webmaster128 webmaster128 deleted the add-Reply-payload branch January 30, 2024 13:04
@amimart amimart mentioned this pull request Aug 6, 2024
Merged
@bdeneux bdeneux mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reply should contain the original payload from the triggering SubMsg
2 participants
@webmaster128 @chipshort