-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fingerprint alg #137
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit lacks the signoff part. I don't think it is a good idea if I write it for you and force push, so please add it yourself. Thanks!
The code looks good to me. We need a newsfile entry, but I can make it for you.
…ngerprint-alg Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
c5fc4f9
to
4cc0353
Compare
I've rebased, fixed the signoff and added the news entry. btw, @MrAnno this PR now allows to trust specific keys, even if their X.509 validation fails. The code did not support it thus far, but I think this has always been the intention. Currently, trusted-keys() will only trust keys that are otherwise trusted, which does not make much sense to me. The documentation is not that clear on this topic either (@fekete-robert). |
From #136:
I can implement the missing parts next week. |
This branch allows you to specify the fingerprint-alg() to be used for validating key fingerprints in trusted-keys()
Fixes: syslog-ng/syslog-ng#4976